[PATCH 0/3] watchdog: don't print superfluous errors

[PATCH 0/3] watchdog: don't print superfluous errors

[Wolfram Sang]

I found this needless printout in the Renesas RZ drivers. Then, I
updated an existing coccinelle script to find more of these in the tree.

No dependencies, buildbot is happy, based on v6.17-rc1.


Wolfram Sang (3):
  watchdog: rzg2l_wdt: don't print superfluous errors
  watchdog: rzv2h_wdt: don't print superfluous errors
  watchdog: visconti: don't print superfluous errors

 drivers/watchdog/rzg2l_wdt.c    | 4 +---
 drivers/watchdog/rzv2h_wdt.c    | 4 +---
 drivers/watchdog/visconti_wdt.c | 5 +----
 3 files changed, 3 insertions(+), 10 deletions(-)

-- 
2.47.2

[PATCH 1/3] watchdog: rzg2l_wdt: don't print superfluous errors

[Wolfram Sang]

The watchdog core will handle error messages already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/rzg2l_wdt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c
index 11bbe48160ec..1c9aa366d0a0 100644
--- a/drivers/watchdog/rzg2l_wdt.c
+++ b/drivers/watchdog/rzg2l_wdt.c
@@ -310,9 +310,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev)
 	watchdog_set_nowayout(&priv->wdev, nowayout);
 	watchdog_stop_on_unregister(&priv->wdev);
 
-	ret = watchdog_init_timeout(&priv->wdev, 0, dev);
-	if (ret)
-		dev_warn(dev, "Specified timeout invalid, using default");
+	watchdog_init_timeout(&priv->wdev, 0, dev);
 
 	return devm_watchdog_register_device(&pdev->dev, &priv->wdev);
 }
-- 
2.47.2

[PATCH 2/3] watchdog: rzv2h_wdt: don't print superfluous errors

[Wolfram Sang]

The watchdog core will handle error messages already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/rzv2h_wdt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.c
index 8defd0241213..3035b49f012b 100644
--- a/drivers/watchdog/rzv2h_wdt.c
+++ b/drivers/watchdog/rzv2h_wdt.c
@@ -247,9 +247,7 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
 	watchdog_set_nowayout(&priv->wdev, nowayout);
 	watchdog_stop_on_unregister(&priv->wdev);
 
-	ret = watchdog_init_timeout(&priv->wdev, 0, dev);
-	if (ret)
-		dev_warn(dev, "Specified timeout invalid, using default");
+	watchdog_init_timeout(&priv->wdev, 0, dev);
 
 	return devm_watchdog_register_device(dev, &priv->wdev);
 }
-- 
2.47.2

[PATCH 3/3] watchdog: visconti: don't print superfluous errors

[Wolfram Sang]

The watchdog core will handle error messages already.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/watchdog/visconti_wdt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/watchdog/visconti_wdt.c b/drivers/watchdog/visconti_wdt.c
index cef0794708e7..7795e7fbf67e 100644
--- a/drivers/watchdog/visconti_wdt.c
+++ b/drivers/watchdog/visconti_wdt.c
@@ -118,7 +118,6 @@ static int visconti_wdt_probe(struct platform_device *pdev)
 	struct visconti_wdt_priv *priv;
 	struct device *dev = &pdev->dev;
 	struct clk *clk;
-	int ret;
 	unsigned long clk_freq;
 
 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -153,9 +152,7 @@ static int visconti_wdt_probe(struct platform_device *pdev)
 	watchdog_stop_on_unregister(wdev);
 
 	/* This overrides the default timeout only if DT configuration was found */
-	ret = watchdog_init_timeout(wdev, 0, dev);
-	if (ret)
-		dev_warn(dev, "Specified timeout value invalid, using default\n");
+	watchdog_init_timeout(wdev, 0, dev);
 
 	return devm_watchdog_register_device(dev, wdev);
 }
-- 
2.47.2

Re: [PATCH 1/3] watchdog: rzg2l_wdt: don't print superfluous errors

[Guenter Roeck]

On 8/13/25 12:05, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH 2/3] watchdog: rzv2h_wdt: don't print superfluous errors

[Guenter Roeck]

On 8/13/25 12:05, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH 3/3] watchdog: visconti: don't print superfluous errors

[Guenter Roeck]

On 8/13/25 12:05, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>

RE: [PATCH 3/3] watchdog: visconti: don't print superfluous errors

[nobuhiro.iwamatsu.x90]

Hello,

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: Thursday, August 14, 2025 4:05 AM
> To: linux-watchdog@vger.kernel.org
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>; Wim Van
> Sebroeck <wim@linux-watchdog.org>; Guenter Roeck <linux@roeck-us.net>;
> iwamatsu nobuhiro(岩松 信洋 □ＤＩＴＣ○ＣＰＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 3/3] watchdog: visconti: don't print superfluous errors
> 
> The watchdog core will handle error messages already.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  drivers/watchdog/visconti_wdt.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/visconti_wdt.c
> b/drivers/watchdog/visconti_wdt.c index cef0794708e7..7795e7fbf67e 100644
> --- a/drivers/watchdog/visconti_wdt.c
> +++ b/drivers/watchdog/visconti_wdt.c
> @@ -118,7 +118,6 @@ static int visconti_wdt_probe(struct platform_device
> *pdev)
>  	struct visconti_wdt_priv *priv;
>  	struct device *dev = &pdev->dev;
>  	struct clk *clk;
> -	int ret;
>  	unsigned long clk_freq;
> 
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); @@ -153,9
> +152,7 @@ static int visconti_wdt_probe(struct platform_device *pdev)
>  	watchdog_stop_on_unregister(wdev);
> 
>  	/* This overrides the default timeout only if DT configuration was
> found */
> -	ret = watchdog_init_timeout(wdev, 0, dev);
> -	if (ret)
> -		dev_warn(dev, "Specified timeout value invalid, using
> default\n");
> +	watchdog_init_timeout(wdev, 0, dev);
> 
>  	return devm_watchdog_register_device(dev, wdev);  }

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.x90@mail.toshiba>

Best regards,
  Nobuhiro