linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* watchdog: cpwd: Clarify wd*_timeout parameters
@ 2025-08-19  2:51 I Viswanath
  2025-08-19  2:51 ` [PATCH] " I Viswanath
  0 siblings, 1 reply; 2+ messages in thread
From: I Viswanath @ 2025-08-19  2:51 UTC (permalink / raw)
  To: wim; +Cc: linux, corbet, linux-watchdog, linux-doc, skhan,
	linux-kernel-mentees

Hello,
  
        It's easy to misread "timeout in 1/10s" as "timeout in either units
of 1 sec or 10 secs". This change should clear that up.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] watchdog: cpwd: Clarify wd*_timeout parameters
  2025-08-19  2:51 watchdog: cpwd: Clarify wd*_timeout parameters I Viswanath
@ 2025-08-19  2:51 ` I Viswanath
  0 siblings, 0 replies; 2+ messages in thread
From: I Viswanath @ 2025-08-19  2:51 UTC (permalink / raw)
  To: wim
  Cc: linux, corbet, linux-watchdog, linux-doc, skhan,
	linux-kernel-mentees, I Viswanath

Reword "in 1/10secs" to "in units of 100 ms" in MODULE_PARAM_DESC
and the corresponding documentation to avoid misinterpretation of
the fractional notation.

Signed-off-by: I Viswanath <viswanathiyyappan@gmail.com>
---
 Documentation/watchdog/watchdog-parameters.rst | 6 +++---
 drivers/watchdog/cpwd.c                        | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/watchdog/watchdog-parameters.rst b/Documentation/watchdog/watchdog-parameters.rst
index 0a0119edfa82..4257a59792de 100644
--- a/Documentation/watchdog/watchdog-parameters.rst
+++ b/Documentation/watchdog/watchdog-parameters.rst
@@ -122,11 +122,11 @@ coh901327_wdt:
 
 cpwd:
     wd0_timeout:
-	Default watchdog0 timeout in 1/10secs
+	Default watchdog0 timeout in units of 100 ms
     wd1_timeout:
-	Default watchdog1 timeout in 1/10secs
+	Default watchdog1 timeout in units of 100 ms
     wd2_timeout:
-	Default watchdog2 timeout in 1/10secs
+	Default watchdog2 timeout in units of 100 ms
 
 -------------------------------------------------
 
diff --git a/drivers/watchdog/cpwd.c b/drivers/watchdog/cpwd.c
index 13a4d47e68cd..c0a5c6f274e0 100644
--- a/drivers/watchdog/cpwd.c
+++ b/drivers/watchdog/cpwd.c
@@ -163,11 +163,11 @@ static int wd1_timeout;
 static int wd2_timeout;
 
 module_param(wd0_timeout, int, 0);
-MODULE_PARM_DESC(wd0_timeout, "Default watchdog0 timeout in 1/10secs");
+MODULE_PARM_DESC(wd0_timeout, "Default watchdog0 timeout in units of 100 ms");
 module_param(wd1_timeout, int, 0);
-MODULE_PARM_DESC(wd1_timeout, "Default watchdog1 timeout in 1/10secs");
+MODULE_PARM_DESC(wd1_timeout, "Default watchdog1 timeout in units of 100 ms");
 module_param(wd2_timeout, int, 0);
-MODULE_PARM_DESC(wd2_timeout, "Default watchdog2 timeout in 1/10secs");
+MODULE_PARM_DESC(wd2_timeout, "Default watchdog2 timeout in units of 100 ms");
 
 MODULE_AUTHOR("Eric Brower <ebrower@usa.net>");
 MODULE_DESCRIPTION("Hardware watchdog driver for Sun Microsystems CP1400/1500");
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-08-19  2:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19  2:51 watchdog: cpwd: Clarify wd*_timeout parameters I Viswanath
2025-08-19  2:51 ` [PATCH] " I Viswanath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).