Re: [PATCH 1/2] dt-bindings: watchdog: Add Renesas WWDT

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3016 bytes --]

On Wed, Sep 17, 2025 at 08:56:48PM +0200, Wolfram Sang wrote:
> Describe the Window Watchdog Timer found on Renesas R-Car SoCs from late
> Gen3 onwards.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Passes the binding check here.
> 
>  .../bindings/watchdog/renesas,wwdt.yaml       | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/renesas,wwdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wwdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wwdt.yaml
> new file mode 100644
> index 000000000000..921713dd40fa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,wwdt.yaml

filename matching the base compatible please

> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/renesas,wwdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas Window Watchdog Timer (WWDT) Controller
> +
> +maintainers:
> +  - Wolfram Sang <wsa+renesas@sang-engineering.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: renesas,r8a779g0-wwdt  # V4H
> +      - const: renesas,rcar-gen4-wwdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    items:
> +      - description: Pretimeout, 75% of overflow reached
> +      - description: Error occurred
> +
> +  interrupt-names:
> +    items:
> +      - const: pretimeout
> +      - const: error
> +
> +  clocks:
> +    items:
> +      - description: Bus clock
> +      - description: Counting clock
> +
> +  clock-names:
> +    items:
> +      - const: bus
> +      - const: cnt
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - resets
> +  - power-domains
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/r8a779g0-cpg-mssr.h>
> +    #include <dt-bindings/power/r8a779g0-sysc.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    wwdt0: watchdog@ffc90000 {

and remove the wwwdt0 label here as it has no users.

> +            compatible = "renesas,r8a779g0-wwdt",
> +                         "renesas,rcar-gen4-wwdt";
> +            reg = <0xffc90000 0x10>;
> +            interrupts = <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
> +                         <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>;
> +            interrupt-names = "pretimeout", "error";
> +            clocks = <&cpg CPG_CORE R8A779G0_CLK_SASYNCRT>,
> +                     <&cpg CPG_CORE R8A779G0_CLK_R>;
> +            clock-names = "bus", "cnt";
> +            power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> +            resets = <&cpg 1200>;
> +    };
> -- 
> 2.47.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]