Re: [PATCH v2] fix it87_wdt early reboot w/ FW started timer

Guenter Roeck
2025-11-16T23:59:50Z

On 11/16/25 11:42, René Rebe wrote:
> On Sun, 16 Nov 2025 08:22:39 -0800,
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>> This is not a reason for a log message, much less for a warning.
>>
>>> + wdt_dev.max_hw_heartbeat_ms = timeout * 1000;
>>
>> This should be set instead of setting max_timeout.
>
> After debugging, reading the core source and RTFM apparently not. As
> the time can be changed and thus .max_hw_heartbeat_ms should
> apparently not be set at all unlike you initially suggested. AFAICS it
> is the regular .timeout and .max_timeout we want to keep setting.
>

You are correct here. My understanding wqas wrong - I though the problem
was that updating the timeout was disabled by the kernel, but the problem
was just that the timeout was enabled by the BIOS. So all that needs to
be done is what was done in w83627hf_wdt.c - mark the watchdog as running
if that is the case.

Guenter