* [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option
@ 2025-11-23 20:24 Oleksandr Suvorov
2025-11-23 20:34 ` Guenter Roeck
2025-11-24 17:12 ` Frank Li
0 siblings, 2 replies; 3+ messages in thread
From: Oleksandr Suvorov @ 2025-11-23 20:24 UTC (permalink / raw)
To: linux-kernel
Cc: Oleksandr Suvorov, Fabio Estevam, Guenter Roeck,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo,
Wim Van Sebroeck, imx, linux-arm-kernel, linux-watchdog
The module parameter `nowayout` indicates whether the watchdog should ever
be allowed to stop, but the driver currently ignores this option.
Pass the `nowayout` parameter to the watchdog core by setting the
WDOG_NO_WAY_OUT flag accordingly.
Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
---
drivers/watchdog/imx7ulp_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c
index 0f13a30533574..03479110453ce 100644
--- a/drivers/watchdog/imx7ulp_wdt.c
+++ b/drivers/watchdog/imx7ulp_wdt.c
@@ -346,6 +346,7 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev)
watchdog_stop_on_reboot(wdog);
watchdog_stop_on_unregister(wdog);
watchdog_set_drvdata(wdog, imx7ulp_wdt);
+ watchdog_set_nowayout(wdog, nowayout);
imx7ulp_wdt->hw = of_device_get_match_data(dev);
ret = imx7ulp_wdt_init(imx7ulp_wdt, wdog->timeout * imx7ulp_wdt->hw->wdog_clock_rate);
--
2.43.0
base-commit: 1af5c1d3a90246a15225fc7de0ed7e5f9b2f3f98
branch: master-imc7ulp_wdt-nowayout
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option
2025-11-23 20:24 [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option Oleksandr Suvorov
@ 2025-11-23 20:34 ` Guenter Roeck
2025-11-24 17:12 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2025-11-23 20:34 UTC (permalink / raw)
To: Oleksandr Suvorov, linux-kernel
Cc: Fabio Estevam, Pengutronix Kernel Team, Sascha Hauer, Shawn Guo,
Wim Van Sebroeck, imx, linux-arm-kernel, linux-watchdog
On 11/23/25 12:24, Oleksandr Suvorov wrote:
> The module parameter `nowayout` indicates whether the watchdog should ever
> be allowed to stop, but the driver currently ignores this option.
>
> Pass the `nowayout` parameter to the watchdog core by setting the
> WDOG_NO_WAY_OUT flag accordingly.
>
> Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ---
>
> drivers/watchdog/imx7ulp_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c
> index 0f13a30533574..03479110453ce 100644
> --- a/drivers/watchdog/imx7ulp_wdt.c
> +++ b/drivers/watchdog/imx7ulp_wdt.c
> @@ -346,6 +346,7 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev)
> watchdog_stop_on_reboot(wdog);
> watchdog_stop_on_unregister(wdog);
> watchdog_set_drvdata(wdog, imx7ulp_wdt);
> + watchdog_set_nowayout(wdog, nowayout);
>
> imx7ulp_wdt->hw = of_device_get_match_data(dev);
> ret = imx7ulp_wdt_init(imx7ulp_wdt, wdog->timeout * imx7ulp_wdt->hw->wdog_clock_rate);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option
2025-11-23 20:24 [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option Oleksandr Suvorov
2025-11-23 20:34 ` Guenter Roeck
@ 2025-11-24 17:12 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2025-11-24 17:12 UTC (permalink / raw)
To: Oleksandr Suvorov
Cc: linux-kernel, Fabio Estevam, Guenter Roeck,
Pengutronix Kernel Team, Sascha Hauer, Shawn Guo,
Wim Van Sebroeck, imx, linux-arm-kernel, linux-watchdog
On Sun, Nov 23, 2025 at 10:24:33PM +0200, Oleksandr Suvorov wrote:
> The module parameter `nowayout` indicates whether the watchdog should ever
> be allowed to stop, but the driver currently ignores this option.
>
> Pass the `nowayout` parameter to the watchdog core by setting the
> WDOG_NO_WAY_OUT flag accordingly.
>
> Signed-off-by: Oleksandr Suvorov <cryosay@gmail.com>
>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> drivers/watchdog/imx7ulp_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/imx7ulp_wdt.c b/drivers/watchdog/imx7ulp_wdt.c
> index 0f13a30533574..03479110453ce 100644
> --- a/drivers/watchdog/imx7ulp_wdt.c
> +++ b/drivers/watchdog/imx7ulp_wdt.c
> @@ -346,6 +346,7 @@ static int imx7ulp_wdt_probe(struct platform_device *pdev)
> watchdog_stop_on_reboot(wdog);
> watchdog_stop_on_unregister(wdog);
> watchdog_set_drvdata(wdog, imx7ulp_wdt);
> + watchdog_set_nowayout(wdog, nowayout);
>
> imx7ulp_wdt->hw = of_device_get_match_data(dev);
> ret = imx7ulp_wdt_init(imx7ulp_wdt, wdog->timeout * imx7ulp_wdt->hw->wdog_clock_rate);
> --
> 2.43.0
>
> base-commit: 1af5c1d3a90246a15225fc7de0ed7e5f9b2f3f98
> branch: master-imc7ulp_wdt-nowayout
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-24 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-23 20:24 [PATCH] watchdog: imx7ulp_wdt: handle the nowayout option Oleksandr Suvorov
2025-11-23 20:34 ` Guenter Roeck
2025-11-24 17:12 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox