* [PATCH] watchdog: diag288_wdt: Remove KMSG_COMPONENT macro
@ 2025-11-26 14:43 Heiko Carstens
2025-11-26 15:40 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2025-11-26 14:43 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, linux-watchdog
The KMSG_COMPONENT macro is a leftover of the s390 specific "kernel message
catalog" from 2008 [1] which never made it upstream.
The macro was added to s390 code to allow for an out-of-tree patch which
used this to generate unique message ids. Also this out-of-tree doesn't
exist anymore.
Remove the macro in order to get rid of a pointless indirection.
[1] https://lwn.net/Articles/292650/
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
drivers/watchdog/diag288_wdt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/watchdog/diag288_wdt.c b/drivers/watchdog/diag288_wdt.c
index 887d5a6c155b..9daed2758ae5 100644
--- a/drivers/watchdog/diag288_wdt.c
+++ b/drivers/watchdog/diag288_wdt.c
@@ -18,8 +18,7 @@
*
*/
-#define KMSG_COMPONENT "diag288_wdt"
-#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
+#define pr_fmt(fmt) "diag288_wdt: " fmt
#include <linux/init.h>
#include <linux/kernel.h>
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: diag288_wdt: Remove KMSG_COMPONENT macro
2025-11-26 14:43 [PATCH] watchdog: diag288_wdt: Remove KMSG_COMPONENT macro Heiko Carstens
@ 2025-11-26 15:40 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-11-26 15:40 UTC (permalink / raw)
To: Heiko Carstens, Wim Van Sebroeck, linux-watchdog
On 11/26/25 06:43, Heiko Carstens wrote:
> The KMSG_COMPONENT macro is a leftover of the s390 specific "kernel message
> catalog" from 2008 [1] which never made it upstream.
>
> The macro was added to s390 code to allow for an out-of-tree patch which
> used this to generate unique message ids. Also this out-of-tree doesn't
> exist anymore.
>
> Remove the macro in order to get rid of a pointless indirection.
>
> [1] https://lwn.net/Articles/292650/
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-26 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 14:43 [PATCH] watchdog: diag288_wdt: Remove KMSG_COMPONENT macro Heiko Carstens
2025-11-26 15:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox