Re: [PATCH 4/8] dt-bindings: mfd: Add AAEON embedded controller binding

Krzysztof Kozlowski
2025-12-12T08:22:21Z

On 12/12/2025 08:41, Thomas Perrot (Schneider Electric) wrote:
> Add device tree binding documentation for the AAEON embedded controller
> (MCU). This microcontroller is found on AAEON embedded boards and provides
> system features such as GPIO control, watchdog timer, and LED management.

A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>
> The MCU is connected via I2C and acts as a multi-function device with
> GPIO and watchdog as child nodes.
>
> Signed-off-by: Thomas Perrot (Schneider Electric) <thomas.perrot@bootlin.com>
> ---
> .../bindings/mfd/aaeon,srg-imx8pl-mcu.yaml | 58 ++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8pl-mcu.yaml b/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8pl-mcu.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..680d06a7e7cb3754bdfc67a1b8c484811eba55d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8pl-mcu.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/aaeon,srg-imx8pl-mcu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AAEON Embedded Controller
> +
> +maintainers:
> + - Jérémie Dautheribes <jeremie.dautheribes@bootlin.com>
> + - Thomas Perrot <thomas.perrot@bootlin.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + AAEON embeds a microcontroller on their embedded boards providing system
> + features such as GPIO control, watchdog timer, and LED management.
> + The MCU is connected via I2C bus.
> +
> +properties:
> + compatible:
> + const: aaeon,srg-imx8pl-mcu

What is srg? Why isn't this explained anywhere here?

> +
> + reg:
> + maxItems: 1
> +
> + gpio:

Drop the child, properties go here directly.

> + $ref: /schemas/gpio/aaeon,srg-imx8pl-gpio.yaml
> +
> + watchdog:

Same here

> + $ref: /schemas/watchdog/aaeon,srg-imx8pl-wdt.yaml
> +
> +required:
> + - compatible
> + - reg
> +

Best regards,
Krzysztof