From: Qiliang Yuan <realwujing@gmail.com>
To: dianders@chromium.org
Cc: akpm@linux-foundation.org, lihuafei1@huawei.com,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
mingo@kernel.org, mm-commits@vger.kernel.org,
realwujing@gmail.com, song@kernel.org, sunshx@chinatelecom.cn,
thorsten.blum@linux.dev, wangjinchao600@gmail.com,
yangyicong@hisilicon.com, yuanql9@chinatelecom.cn,
zhangjn11@chinatelecom.cn
Subject: Re: [PATCH v6] watchdog/hardlockup: simplify perf event probe and remove per-cpu dependency
Date: Wed, 28 Jan 2026 01:13:44 -0500 [thread overview]
Message-ID: <20260128061350.1716608-1-realwujing@gmail.com> (raw)
In-Reply-To: <CAD=FV=XX0dJ2jEaQ21M4Kas6pbJL0SSCxYhr8-1kqSTEiJP_UA@mail.gmail.com>
Hi Doug,
On Tue, Jan 27, 2026 at 8:08 PM Doug Anderson <dianders@chromium.org> wrote:
> One last note is that your Signed-off-by tags don't match. When I
> apply your patch, I see:
>
> Author: Qiliang Yuan <realwujing@gmail.com>
>
> ...but your Signed-off-by is your "@chinatelecom.cn" address. That's
> generally not okay. You need to do something to make those match.
Thank you for pointing this out. I've updated my git configuration and
the patch to ensure the Signed-off-by matches the Author's Gmail address.
> Given our newest understanding, the cpu_hotplug_disable() isn't truly
> needed anymore, but I'm still good keeping it.
Since the probe is now fully stateless and no longer touches per-cpu
variables, I've opted to remove the redundant cpu_hotplug_disable() in
v7 to make the code cleaner, as you suggested it wasn't strictly necessary.
v7 Link: https://lore.kernel.org/all/20260128060833.1715622-1-realwujing@gmail.com/
Thanks again for your detailed review and guidance!
Best regards,
Qiliang
next prev parent reply other threads:[~2026-01-28 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 2:31 [PATCH v6] watchdog/hardlockup: simplify perf event probe and remove per-cpu dependency Qiliang Yuan
2026-01-28 4:08 ` Doug Anderson
2026-01-28 6:13 ` Qiliang Yuan [this message]
2026-01-28 13:06 ` Qiliang Yuan
2026-01-28 13:51 ` Qiliang Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128061350.1716608-1-realwujing@gmail.com \
--to=realwujing@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=song@kernel.org \
--cc=sunshx@chinatelecom.cn \
--cc=thorsten.blum@linux.dev \
--cc=wangjinchao600@gmail.com \
--cc=yangyicong@hisilicon.com \
--cc=yuanql9@chinatelecom.cn \
--cc=zhangjn11@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox