Re: [PATCH v2 3/6] dt-bindings: watchdog: apple,wdt: Add t8122 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The newly added `apple,t8122-wdt` compatible string will not bind to the watchdog driver because the driver does not match `apple,t8103-wdt` and the schema prevents including the generic `apple,wdt` fallback.
--

commit c2fb9f5326f211450e3923c7641f1f6384822f86
Author: Janne Grunau <j@jannau.net>

dt-bindings: watchdog: apple,wdt: Add t8122 compatible

This commit adds the apple,t8122-wdt compatible string to the apple,wdt
device tree binding. It is added to the branch that restricts the fallback
to apple,t8103-wdt.

> diff --git a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> index 05602678c070d..845b5e8b5abc3 100644
> --- a/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/apple,wdt.yaml
> @@ -16,7 +16,9 @@ properties:
>    compatible:
>      oneOf:
>        - items:
> -          - const: apple,t6020-wdt
> +          - enum:
> +              - apple,t6020-wdt
> +              - apple,t8122-wdt
>            - const: apple,t8103-wdt

Will this prevent the driver from probing on t8122 devices?

This schema requires exactly two compatible strings: apple,t8122-wdt
followed by apple,t8103-wdt. This exact match requirement prevents the
inclusion of the generic apple,wdt fallback string.

Looking at drivers/watchdog/apple_wdt.c, the driver's of_match_table only
matches { .compatible = "apple,wdt" } and does not match apple,t8103-wdt.

If a device tree conforms to this schema by omitting the generic fallback,
does it cause a regression where the driver silently fails to bind?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260505-apple-m3-initial-devicetrees-v2-0-b0c2f3519e0e@jannau.net?part=3