From: sashiko-bot@kernel.org
To: "Sander Vanheule" <sander@svanheule.net>
Cc: devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
linux-watchdog@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: realtek,otto-wdt: Add fallback compatible
Date: Wed, 13 May 2026 20:38:28 +0000 [thread overview]
Message-ID: <20260513203829.4E10FC19425@smtp.kernel.org> (raw)
In-Reply-To: <20260512110848.106620-2-sander@svanheule.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Improper YAML indentation for the new enum sequence will cause `make dt_binding_check` to fail.
--
commit a7861dc20069d6726a660807ddc12d7c2ba28a4c
Author: Sander Vanheule <sander@svanheule.net>
dt-bindings: watchdog: realtek,otto-wdt: Add fallback compatible
This commit adds a fallback compatible for the realtek,otto-wdt watchdog
binding. It duplicates the existing compatibles into a new list structure
to remain compatible with older device trees that use a single compatible
string.
> diff --git a/Documentation/devicetree/bindings/watchdog/realtek,otto-wdt.yaml b/Documentation/devicetree/bindings/watchdog/realtek,otto-wdt.yaml
> --- a/Documentation/devicetree/bindings/watchdog/realtek,otto-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/realtek,otto-wdt.yaml
> @@ -25,11 +25,20 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - realtek,rtl8380-wdt
> - - realtek,rtl8390-wdt
> - - realtek,rtl9300-wdt
> - - realtek,rtl9310-wdt
> + oneOf:
> + - items:
> + - enum:
> + - realtek,rtl8380-wdt
This isn't a runtime bug, but could the YAML indentation for this sequence
cause make dt_binding_check to fail?
The kernel's yamllint configuration enforces indent-sequences. Because these
sequence items start at the exact same indentation level as their parent enum
mapping key, yamllint will flag this as an indentation error.
> + - realtek,rtl8390-wdt
> + - realtek,rtl9300-wdt
> + - realtek,rtl9310-wdt
> + - const: realtek,otto-wdt
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260512110848.106620-1-sander@svanheule.net?part=1
next prev parent reply other threads:[~2026-05-13 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 11:08 [PATCH 0/2] watchdog: realtek-otto: add fallback compatible Sander Vanheule
2026-05-12 11:08 ` [PATCH 1/2] dt-bindings: watchdog: realtek,otto-wdt: Add " Sander Vanheule
2026-05-12 12:43 ` Rob Herring (Arm)
2026-05-13 20:38 ` sashiko-bot [this message]
2026-05-12 11:08 ` [PATCH 2/2] watchdog: realtek-otto: add " Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260513203829.4E10FC19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox