From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 1/2] watchdog: ath79_wdt: select OF and COMPILE_TEST
Date: Fri, 22 May 2026 23:38:55 +0000 [thread overview]
Message-ID: <20260522233855.CB1FE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260522232553.44748-2-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to 'Select OF in Kconfig', but the patch actually uses `depends on OF`.
--
commit dd7e4233a00f2440d964fb07f7978a246e1b7c28
Author: Rosen Penev <rosenp@gmail.com>
watchdog: ath79_wdt: select OF and COMPILE_TEST
This commit explicitly requires OF for the ath79_wdt driver and allows
it to be built with COMPILE_TEST on all architectures. It also removes
the CONFIG_OF conditional checks around the match table in the driver.
> watchdog: ath79_wdt: select OF and COMPILE_TEST
>
> This has always been an OF driver. Select OF in Kconfig.
[Severity: Medium]
The commit message states that it selects OF in Kconfig, but the patch
actually implements this using "depends on OF".
Does the commit subject and body need updating to accurately reflect the
implementation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260522232553.44748-1-rosenp@gmail.com?part=1
next prev parent reply other threads:[~2026-05-22 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 23:25 [PATCH 0/2] watchdog: ath79: modernize and broaden build coverage Rosen Penev
2026-05-22 23:25 ` [PATCH 1/2] watchdog: ath79_wdt: select OF and COMPILE_TEST Rosen Penev
2026-05-22 23:38 ` sashiko-bot [this message]
2026-05-22 23:25 ` [PATCH 2/2] watchdog: ath79: convert to watchdog_device Rosen Penev
2026-05-23 0:02 ` sashiko-bot
2026-05-22 23:43 ` [PATCH 0/2] watchdog: ath79: modernize and broaden build coverage Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522233855.CB1FE1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox