Re: [PATCH v2 1/7] dt-bindings: reset: Add MT6589 toprgu reset IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds reset provider capabilities for MT6589 without updating the corresponding YAML schema to require `#reset-cells`.
--

--- Patch [1]: [PATCH v2 1/7] dt-bindings: reset: Add MT6589 toprgu reset IDs ---
commit 1610507569a41df45fcf55f93c1df6323ff7d422
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>

dt-bindings: reset: Add MT6589 toprgu reset IDs

This commit introduces the reset constants for the 12 MT6589 toprgu
resets to be used as a reset provider.

> diff --git a/include/dt-bindings/reset/mediatek,mt6589-resets.h b/include/dt-bindings/reset/mediatek,mt6589-resets.h
> new file mode 100644
> index 0000000000000..ee08c39df5131
> --- /dev/null
> +++ b/include/dt-bindings/reset/mediatek,mt6589-resets.h
> @@ -0,0 +1,24 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_CONTROLLER_MT6589
> +#define _DT_BINDINGS_RESET_CONTROLLER_MT6589
> +
> +/* TOPRGU resets */

[Severity: Low]
Does Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml need to
be updated to require #reset-cells when using mediatek,mt6589-wdt?

When adding reset provider capabilities for a hardware variant, the schema
typically requires an allOf/if-then block to add #reset-cells to the required
list. Without this update, a device tree node utilizing the MT6589 watchdog
as a reset provider could omit #reset-cells and still silently pass
dt_binding_check validation.

> +#define MT6589_TOPRGU_INFRA_SW_RST		0
> +#define MT6589_TOPRGU_MM_SW_RST			1

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717163959.714561-1-l.scorcia@gmail.com?part=1