Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mayank Rungta <mrungta@google.com>
Cc: Mayank Rungta via B4 Relay
	<devnull+mrungta.google.com@kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module
Date: Fri, 31 Jul 2026 14:01:42 -0700	[thread overview]
Message-ID: <20260731140142.7d77cfd7e9f99f25880efd32@linux-foundation.org> (raw)
In-Reply-To: <CABz7rdCZkzBv-horH0jNLeNuhCNUOaC+Ttkf_-g3CoCaCSfBbg@mail.gmail.com>

On Thu, 30 Jul 2026 16:39:14 -0700 Mayank Rungta <mrungta@google.com> wrote:

> On Thu, Jul 30, 2026 at 3:50 PM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Thu, 30 Jul 2026 15:00:20 -0700 Mayank Rungta via B4 Relay <devnull+mrungta.google.com@kernel.org> wrote:
> >
> > > All other watchdog pretimeout governors (noop, panic) can be built as
> > > loadable modules. However the "dump" pretimeout governor is restricted
> > > to built-in code because it calls trigger_all_cpu_backtrace(), which
> > > relies on arch_trigger_cpumask_backtrace(), an arch specific helper that
> > > is not exported to loadable modules.
> > >
> > > This 2-patch series allows building the dump governor as a module (=m):
> > > 1) Export cpumask_backtrace() in lib/nmi_backtrace.c.
> > > 2) Convert CONFIG_WATCHDOG_PRETIMEOUT_GOV_DUMP from bool to tristate.
> >
> > LGTM.  Can you please redo against current mainline?  The Kconfig has
> > changed.
> >
> 
> Thanks for the LGTM!
> 
> Regarding rebasing onto mainline (origin/master): The "dump"
> pretimeout governor was added recently by Tzung-Bi Shih ("watchdog:
> pretimeout: Add "dump" pretimeout governor") and is currently in
> linux-next, so it hasn't landed in mainline tree yet.
> 
> Because of this dependency, I based this series on linux-next so that
> patch 2/2 ("Convert dump pretimeout governor to tristate") could apply
> cleanly on top of the new governor.
> 
> Please let me know what is preferred, or if you'd like me to post
> against a different tree!
> 

Oh, OK.

Guenter, can you please process this patchset?

  reply	other threads:[~2026-07-31 21:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-30 22:00 [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module Mayank Rungta via B4 Relay
2026-07-30 22:00 ` [PATCH 1/2] nmi: Export CPU backtrace APIs for loadable modules Mayank Rungta via B4 Relay
2026-07-31  1:54   ` Doug Anderson
2026-08-06 21:40   ` Guenter Roeck
2026-08-06 23:44   ` Andrew Morton
2026-08-07  3:50   ` Guenter Roeck
2026-07-30 22:00 ` [PATCH 2/2] watchdog: pretimeout: Convert dump pretimeout governor to tristate Mayank Rungta via B4 Relay
2026-07-31  1:55   ` Doug Anderson
2026-08-01 12:38   ` Tzung-Bi Shih
2026-08-06 21:41   ` Guenter Roeck
2026-08-06 23:44   ` Andrew Morton
2026-08-07  3:50   ` Guenter Roeck
2026-07-30 22:50 ` [PATCH 0/2] watchdog: pretimeout: Allow building dump governor as module Andrew Morton
2026-07-30 23:39   ` Mayank Rungta
2026-07-31 21:01     ` Andrew Morton [this message]
2026-07-31 21:19       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260731140142.7d77cfd7e9f99f25880efd32@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=devnull+mrungta.google.com@kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mrungta@google.com \
    --cc=tzungbi@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox