Re: [PATCH 6/6] arm64: dts: apple: Add minimal MacBook Neo device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree unit address mismatch for the memory node.
--

commit 7bec9f4da6b6b3c3359561db2b7a13c4d806d885
Author: Yureka Lilian <yureka@cyberchaos.dev>

arm64: dts: apple: Add minimal MacBook Neo device tree

This commit adds a minimal device tree for the MacBook Neo, based on the
t8140 SoC (A18 Pro). It includes basic devices like CPU cores, interrupt
controller, watchdog, and serial, allowing the machine to boot on a single
core using the macOS 26.6.2 firmware.

> diff --git a/arch/arm64/boot/dts/apple/t8140-j700.dts b/arch/arm64/boot/dts/apple/t8140-j700.dts
> new file mode 100644
> index 0000000000000..029d6fdda3ade
> --- /dev/null
> +++ b/arch/arm64/boot/dts/apple/t8140-j700.dts

[ ... ]

> +	reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +		/* To be filled by loader */
> +	};
> +
> +	memory@800000000 {
> +		device_type = "memory";
> +		reg = <0x100 0 0x2 0>; /* To be filled by loader */

[Severity: Low]
Does this code cause a device tree compiler warning? The node is named with
unit address 800000000 (which implies a reg base of <0x8 0>), but the reg
property specifies <0x100 0> (which implies a unit address of 10000000000).

This mismatch between the unit address and the base address in the reg
property typically causes the dtc compiler to emit a 'unit_address_vs_reg'
or 'simple-bus unit address format error' warning when compiling
t8140-j700.dts.

> +	};
> +};
> +
> +&serial0 {
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-apple-a18-pro-initial-devicetrees-v1-0-0c25401d165d@cyberchaos.dev?part=6