Re: [PATCH v5 3/8] dt-bindings: watchdog: Add compatible for MediaTek mt8167

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing required property constraint for new provider capabilities
--

commit 1623803f044eb5bb4bdac92465a186ae36fe6a1a
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>

dt-bindings: watchdog: Add compatible for MediaTek mt8167

Currently mt8167 inherits its watchdog from the included mt8516 dtsi,
which in turn falls back on mt6589-wdt. However according to the data
sheet mt8167 toprgu is not actually compatible with mt6589 (it has 14 sw
resets instead of 12, and its reset bit map table is different from
mt6589).

Update the mtk-wdt binding to add a dedicated compatible for mt8167 and
add the IDs that can be used in device trees to identify subsystem resets.

> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> index 953629cb9558b..f514be8a5851d 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -26,6 +26,7 @@ properties:
>            - mediatek,mt6795-wdt
>            - mediatek,mt7986-wdt
>            - mediatek,mt7988-wdt
> +          - mediatek,mt8167-wdt

[Severity: Medium]
Should #reset-cells be added as a conditionally required property for this
new compatible?

Since this patch adds reset provider capabilities to the hardware (defining
reset IDs in include/dt-bindings/reset/mediatek,mt8167-wdt.h), the schema
needs to ensure #reset-cells is conditionally required for this variant.

Without adding #reset-cells to a required list for mediatek,mt8167-wdt
under properties:compatible:oneOf or via an allOf block, a device tree
node omitting it will silently pass dt_binding_check validation. This allows
incomplete configurations that will fail at runtime when dependent nodes try
to consume the resets.

>            - mediatek,mt8183-wdt
>            - mediatek,mt8186-wdt
>            - mediatek,mt8188-wdt

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908174259.9009-1-l.scorcia@gmail.com?part=3