Re: [PATCH v2 3/8] watchdog: keembay_wdt: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch uses `pm_sleep_ptr()` for the `dev_pm_ops` structure pointer, which contradicts the commit message and violates PM subsystem guidelines.
--

commit c35ef6ee0f1ec7517f550f44b58852af01504c3c
Author: Triet Hoang <triet.hoang.dev@gmail.com>

watchdog: keembay_wdt: Convert to DEFINE_SIMPLE_DEV_PM_OPS()

This commit updates the keembay_wdt driver to use DEFINE_SIMPLE_DEV_PM_OPS(),
allowing the removal of the __maybe_unused annotations on the suspend and
resume callbacks. It also aims to assign the operations using the updated
power management pointer macros.

> diff --git a/drivers/watchdog/keembay_wdt.c b/drivers/watchdog/keembay_wdt.c
> index 7c8e53921e407..2c187b20a5ec1 100644
> --- a/drivers/watchdog/keembay_wdt.c
> +++ b/drivers/watchdog/keembay_wdt.c
[ ... ]
> @@ -284,7 +283,7 @@ static struct platform_driver keembay_wdt_driver = {
>  	.driver	= {
>  		.name		= "keembay_wdt",
>  		.of_match_table	= keembay_wdt_match,
> -		.pm		= &keembay_wdt_pm_ops,
> +		.pm		= pm_sleep_ptr(&keembay_wdt_pm_ops),
>  	},
>  };

[Severity: Medium]
The commit message mentions converting to pm_ptr(), but pm_sleep_ptr() is
used here for the dev_pm_ops structure pointer in keembay_wdt_driver.

According to the power management subsystem guidelines, pm_sleep_ptr()
should be used for individual sleep callbacks, while pm_ptr() should be
used for the dev_pm_ops structure pointer itself. Should this be updated
to use pm_ptr() to match both the subsystem guidelines and the stated
intent in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914085451.891675-1-triet.hoang.dev@gmail.com?part=3