Re: [PATCH] watchdog: introduce the ARM64 SBSA watchdog driver

Hanjun Guo
2015-05-02T13:55:31Z

Hi Timur,

I didn't review it in detail since I'm preparing the
ACPI GICv3 related patches and run out of time, but
I noticed a obvious error, comments inline.

On 2015年04月30日 03:33, Timur Tabi wrote:

> +static int __exit arm_sbsa_wdt_remove(struct platform_device *pdev)
> +{
> + struct arm_sbsa_watchdog_data *data = platform_get_drvdata(pdev);
> +
> + watchdog_unregister_device(&data->wdev);
> +
> + return 0;
> +}
> +
> +static struct platform_device *arm_sbsa_wdt_pdev;
> +
> +static int __init arm_sbsa_wdt_parse_gtdt(struct acpi_subtable_header *header,
> + const unsigned long end)
> +{
> + struct acpi_gtdt_watchdog *wdg = (struct acpi_gtdt_watchdog *)header;

struct acpi_subtable_header can not be used here, because
acpi_subtable_header with the u8 structure length, but
for gtdt watchdog timer structure, its length is u16 defined.

Thanks
Hanjun