Re: [PATCH] watchdog: introduce the ARM64 SBSA watchdog driver

Timur Tabi
2015-05-01T17:41:59Z

On 05/01/2015 12:32 PM, Guenter Roeck wrote:
> devm_ioremap_resource already prints a message. For this reason, elsewhere in the
> kernel the check for !res before calling devm_ioremap_resource is being removed,
> leaving the error handling to devm_ioremap_resource. I would suggest to do the
> same here.

I see what you're saying, but I leave the error handling to
devm_ioremap_resource(), then no one will know whether it's because the
control address or the refresh address is missing. The user will just
see "invalid resource" and won't what resource is actually invalid.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.