Re: [Linaro-acpi] [PATCH] watchdog: introduce the ARM64 SBSA watchdog driver

Timur Tabi
2015-05-01T23:22:11Z

Guenter Roeck wrote:
> Not really, at least not me. However, there is no other caller of
> arch_timer_get_rate, except for the call setting arch_timer_rate.
> This suggests that it might not be such a good idea to call
> arch_timer_get_rate() and arch_timer_read_counter() in the first place.

I don't know of any other way to convert seconds into watchdog ticks.

> [ On a side note, arch_timer_get_rate() can return 0 if ARM_ARCH_TIMER
> is not configured. You'll need to check for that. ]

Check the Kconfig for this driver. It requires ARM_ARCH_TIMER.

> It is hard to imagine that the watchdog would be the only driver which
> needs this clock. Isn't there some clock API call that can be used
> instead ?

If there is, I'd love to know it. There's no 'device' for this driver,
so I don't think the clk API will work.

> As for acpi_parse_entries, we will need some feedback from the acpi
> maintainers. If the intent is that this function can be called from
> drivers, it should be exported.

Agreed.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.