From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937B6C433F5 for ; Mon, 23 May 2022 13:07:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235987AbiEWNHF (ORCPT ); Mon, 23 May 2022 09:07:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236044AbiEWNHA (ORCPT ); Mon, 23 May 2022 09:07:00 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 492EF496B6 for ; Mon, 23 May 2022 06:06:57 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id v9so7866853lja.12 for ; Mon, 23 May 2022 06:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=SDuGMgEXCGQ1TJ0fNHdXQPIRrrbTcF5QRnV15Th8wlnm6ALDsCXQkDhSc30CAXl9Kp lUcwwo8YPG+ToK1ghL+xsLwZPbKsU3Xs5fTm4yRb1VvjTdISvp+ik2qXsRARg60MQYWC GzqnvLsPLHQQ9m8qRk3NoJy44Um8tv0iazTe+dReBMGQpIWhXgY7sW+X5Q92sAdYY4Up yPMCEKh8i9Ozg5XgOdN0UxNO4J+QgBEZh3/Z8fVZf4cnzrU5tlx9D2h6JrtHwCIXtkCT BYpUW9KmlugPMvChcIWuNOw5mvQnQfIPUm4rq/I+cIqgIavTpZd0JMU/RlcgqLJUgwvk OYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=FfNmM4fuGNsJdS8Z+Vg42ceLtA/mxUjuz+DbjPvkxjsBuMdQIs4bn2kY++0a8vZKha GUuCaYgb2wYSfVKnNjuo1kr/tDkyQS3N3bcWVDP/6Oca/WZjPW+Ki6zQeqIedckv9LIW 0o0XPEXjrcluVFZhpbORXBrdP1KKKElebRl1eqGIi+fIYzvFU2Sc7zMyJc6B2KxO+/FZ Uuo6dVsGzYgxP6OUei6N2HDw1lr9/Zd7Quynd/fO2okZlRMCwHkvB/Cqsc+7Kmszr/bX rUjQA+l0MO1uHbI6kXEtkKIfG5B5J1k/YRY+g3iG5snA5l83rrGhIIbTW1ZyHBGGvstF bk3w== X-Gm-Message-State: AOAM5308E3bI+x8R8FUMdOJIXeULoqpuLT7tdFl086z2MRohnZ0bXh6k FNEY7NLVFwLkWN2D7djYm7RQtw== X-Google-Smtp-Source: ABdhPJxW/DBrlG7TEnvWEUg0Nipmvi6wS+g8Y+NMEBmjLhpKfeu4xjRK3q520VX+9jaURA7ei9otVw== X-Received: by 2002:a2e:a26d:0:b0:253:d7b4:1d9a with SMTP id k13-20020a2ea26d000000b00253d7b41d9amr11639775ljm.203.1653311215543; Mon, 23 May 2022 06:06:55 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c6-20020ac24146000000b00477b0cfc990sm1968975lfi.30.2022.05.23.06.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 06:06:55 -0700 (PDT) Message-ID: <2ccfbfa8-be11-50ed-66ca-3476cbddb320@linaro.org> Date: Mon, 23 May 2022 15:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Content-Language: en-US To: Tomer Maimon , Arnd Bergmann Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, nathan=20Neusch=C3=A4fer?= , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On 23/05/2022 14:58, Tomer Maimon wrote: > Hi Arnd, > > Thanks for your comment. > > On Mon, 23 May 2022 at 14:48, Arnd Bergmann > wrote: > > On Sun, May 22, 2022 at 5:50 PM Tomer Maimon > wrote: > > +++ b/drivers/tty/serial/8250/8250_of.c > > @@ -333,6 +333,7 @@ static const struct of_device_id > of_platform_serial_table[] = { > >         { .compatible = "ti,da830-uart", .data = (void > *)PORT_DA830, }, > >         { .compatible = "nuvoton,wpcm450-uart", .data = (void > *)PORT_NPCM, }, > >         { .compatible = "nuvoton,npcm750-uart", .data = (void > *)PORT_NPCM, }, > > +       { .compatible = "nuvoton,npcm845-uart", .data = (void > *)PORT_NPCM, }, > >         { /* end of list */ }, > > If these are compatible devices, it's usually easier to claim > compatibility with both the specific chip and the older model > as a fallback, to avoid driver changes. This seems to apply to > the timer and watchdog devices as well. > > Just to make sure, Do you mean claim in the device tree? > like > > compatible = "nuvoton,npcm845-timer", "nuvoton,npcm-timer"; compatible = "nuvoton,npcm845-timer", "nuvoton,npcm750-timer""; Best regards, Krzysztof