From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA5221ADD2; Fri, 24 Jan 2025 12:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737722496; cv=none; b=Vk7JBYKakfjxPYsvCyzKSb7Q7o09BlYywuTz+zt7Z1iztr6rWGSgVgczXcTVgki9/JDRJC0C6wDMZHUlIVe9Us3VeQvF1STp+HWxp+H+QjV7W56HTpmHuQr9qJDi6Ec/vzOgCCQy8l66BKQX+MnlaLnFxIJaT2HmQGtarSDJfN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737722496; c=relaxed/simple; bh=pmzsGxQ3eYxkGdaZPFtQlbp+tgILJC6MR6rjnvO4HAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z8FvbCCTZ3u89HNmZkUlR6cys2JMdgBLZt/LjEdwGujnUf3SK0NITBap66UStsN9zUev84IYcway5B5H/bXDF1BJ9jOOyK5UO/1h0h3bxAajKL6O3LQishqrjqrtBnOVgs7ILkTJVSGYUymQaimBLvhAwU4CIp8Rmilru/28gcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dd7++koJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dd7++koJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8CAAC4CED2; Fri, 24 Jan 2025 12:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737722495; bh=pmzsGxQ3eYxkGdaZPFtQlbp+tgILJC6MR6rjnvO4HAM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dd7++koJC+ePDwrVIlvD7QbZStz+7IZMEMd2IvSCA7aTJXl/wyiEKl7cc761CS10c Wk0IG8f8zEhi7pl+rjK/mseIE5XYEXquHhGO8SagDc8WMJwdPNubrhrrycoF3W7xi0 C9g3Jfi32qudIHrFzoe+J0UUJnnuKKIT3X8uCdxWMD0LEJCAfiHLFHGhhjcZ/DMfdf vHbI+1PEbWJ78NhWVXTw/ijhwxSxEULD33CSMs+r7fHOhzkPznVV3IY+xwOiaIJrBw H/QsDclKytzwrTO3TwvJe/Fi4wxMkPVVdSDBnI5ydPzBiOfE9uEzmBcmgMnFXfunGE c0EBTHLSU2l2w== Message-ID: <305ba07f-e5f3-4d2e-b017-8a817418f16c@kernel.org> Date: Fri, 24 Jan 2025 13:41:30 +0100 Precedence: bulk X-Mailing-List: linux-watchdog@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47 To: Biju Das Cc: Wim Van Sebroeck , Guenter Roeck , "linux-watchdog@vger.kernel.org" , Geert Uytterhoeven , Prabhakar Mahadev Lad , "biju.das.au" , "linux-renesas-soc@vger.kernel.org" References: <20250115103858.104709-1-biju.das.jz@bp.renesas.com> <20250115103858.104709-4-biju.das.jz@bp.renesas.com> <20250118-trout-of-luxurious-inquire-aae9aa@krzk-bin> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/01/2025 11:57, Biju Das wrote: > Hi Krzysztof Kozlowski, > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: 24 January 2025 10:35 >> Subject: Re: [PATCH 3/5] watchdog: Make RZV2HWDT driver depend on ARCH_R9A09G47 >> >> On 24/01/2025 11:20, Biju Das wrote: >>>> >>>>> + depends on ARCH_R9A09G047 || ARCH_R9A09G057 || COMPILE_TEST >>>> >>>> But this is just wrong. You are supposed to depend on renesas ARHC, >>>> not your individual SoC (and this is what you called here "ARCH_R9A..."). >>>> >>>> Greg many times gave strong opinion that even full ARCH is wrong and >>>> we managed to convince him that it has a meaning (or he did not want >>>> to keep discussing). But restricting it per soc is pointless and impossible to defend in >> discussion. >>> >>> Currently for building RZ/G3E WDT, I need to always have RZ/V2H SoC config. >>> which is pointless. May be ARCH_RENESAS should ok in this case?? >> Assuming ARCH_RENESAS covers your individual SoCs above, yes, that's the way for driver to limit >> themselves to usable family. > > ARCH_RENESAS has ARM, ARM64 and RISC based SoCs. > > Currently it covers ARCH_RCAR_GEN1, ARCH_RCAR_GEN2, > ARCH_RCAR_GEN3, ARCH_RCAR_GEN4, ARCH_RMOBILE, ARCH_RZG2L, ARCH_RZN1 > Family SOCs and rest of the individual SoCs such as RZ/V2H abnd RZ/g3E. Rather tell me why this is supposed to be different than other vendors? || ARM64 is already used solution > > Since most of IP's in RZ/V2H and RZ/G3E are identical we could introduce > a new family SoC ARCH_RZG3E_RZV2H to cover both or top level ARCH_RENESAS?? You should not write drivers per SoCs (or even two or there SoCs) and there is really no need to restrict them per each SoC. Otherwise come with arguments to my first question: why do you need exception here from generic kernel approach? Best regards, Krzysztof