From: "Li, Hua Qian" <HuaQian.Li@siemens.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "kristo@kernel.org" <kristo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"huaqianlee@gmail.com" <huaqianlee@gmail.com>,
"nm@ti.com" <nm@ti.com>, "vigneshr@ti.com" <vigneshr@ti.com>,
"Kiszka, Jan" <jan.kiszka@siemens.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Su, Bao Cheng" <baocheng.su@siemens.com>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x
Date: Mon, 17 Jul 2023 06:28:44 +0000 [thread overview]
Message-ID: <33a1f28a68483bd8b0e91e8953490814bae4fe5d.camel@siemens.com> (raw)
In-Reply-To: <e57e5d8efc3107b5f2c4e66492650b9d0c17b898.camel@siemens.com>
On Mon, 2023-07-17 at 14:23 +0800, Hua Qian Li wrote:
> On Mon, 2023-07-17 at 08:16 +0200, Krzysztof Kozlowski wrote:
> > On 17/07/2023 06:07, huaqian.li@siemens.com wrote:
> > > From: Li Hua Qian <huaqian.li@siemens.com>
> > >
> > > The watchdog hardware of TI AM65X platform does not support
> > > WDIOF_CARDRESET feature, add a reserved memory to save the
> > > watchdog
> > > reset cause, to know if the board reboot is due to a watchdog
> > > reset.
> > >
> > > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
> > > ---
> > > Changes in v4:
> > > - Fix the coding style.
> > > - Add usage note for the reserved memory.
> > > - Link to v3:
> > >
> > > https://lore.kernel.org/linux-watchdog/20230713095127.1230109-1-huaqian.li@siemens.com
> >
> > Much more changed. You added example in the bindings which no one
> > asked
> > for. Then you added multiple fake review tags to all the patches.
> >
> > Best regards,
> > Krzysztof
> >
> Hi,
>
> Sorry for the wrong statement. I missed some key information and
> missunderstood `Reviewed-by`, I treated `Reviewed-by` as `Who
> has reviewed`.
>
> Best regards,
> Li Hua Qian
By the way, `Much more changes` came from the following message which
was commented on [PATCH v3 0/3] Add support for WDIOF_CARDRESET on TI
AM65x:
One thing I keep wondering about: What prevents the Linux kernel from
treating the special memory area like normal memory ? I would have
expected
some usage note, such as that the memory area must be reported as
reserved
to the kernel, but I don't see anything like that.
Guenter
prev parent reply other threads:[~2023-07-17 6:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 4:07 [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x huaqian.li
2023-07-17 4:07 ` [PATCH v4 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-17 5:15 ` Guenter Roeck
2023-07-17 7:13 ` Li, Hua Qian
2023-07-17 6:13 ` Krzysztof Kozlowski
2023-07-17 6:15 ` Krzysztof Kozlowski
2023-07-17 7:17 ` Conor Dooley
2023-07-17 7:23 ` Li, Hua Qian
2023-07-17 4:07 ` [DONOTMERGE PATCH v4 2/3] arm64: dts: ti: Add reserved memory for watchdog huaqian.li
2023-07-17 6:14 ` Krzysztof Kozlowski
2023-07-17 4:07 ` [PATCH v4 3/3] watchdog:rit_wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-17 6:14 ` Krzysztof Kozlowski
2023-07-17 6:16 ` [PATCH v4 0/3] Add support for WDIOF_CARDRESET on TI AM65x Krzysztof Kozlowski
2023-07-17 6:24 ` Li, Hua Qian
2023-07-17 6:27 ` Krzysztof Kozlowski
2023-07-17 6:34 ` Li, Hua Qian
2023-07-17 6:43 ` Krzysztof Kozlowski
2023-07-17 6:49 ` Li, Hua Qian
2023-07-17 6:28 ` Li, Hua Qian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a1f28a68483bd8b0e91e8953490814bae4fe5d.camel@siemens.com \
--to=huaqian.li@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=huaqianlee@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).