From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 01/16] watchdog: refactor watchdog_init_timeout
Date: Mon, 15 Apr 2019 11:21:13 +0300 [thread overview]
Message-ID: <35407697-cbbb-e72b-7aed-ed84a3beb669@cogentembedded.com> (raw)
In-Reply-To: <20190414102627.5564-2-wsa+renesas@sang-engineering.com>
Hello!
On 14.04.2019 13:26, Wolfram Sang wrote:
> The function is not easy to read and has two problems: a) -EINVAL is
> returned when the module parameter is invalid but the DT parameter is
> OK, and b) for the module parameter, zero is a valid value but for DT it
> is invalid.
>
> Refactor the code to have a the same pattern of checks for the module
^^^^^
One article would be enough. :-)
> parameter and DT. Further ones can be easily added in the future if the
> need arises. The above mentioned problems are fixed, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-04-15 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 10:26 [PATCH 00/16] watchdog: refactor init_timeout and update users Wolfram Sang
2019-04-14 10:26 ` [PATCH 01/16] watchdog: refactor watchdog_init_timeout Wolfram Sang
2019-04-14 13:25 ` Guenter Roeck
2019-04-14 13:42 ` Wolfram Sang
2019-04-14 14:03 ` Guenter Roeck
2019-04-15 8:21 ` Sergei Shtylyov [this message]
2019-04-14 10:26 ` [PATCH 02/16] watchdog: add error messages when initializing timeout fails Wolfram Sang
2019-04-14 10:26 ` [PATCH 03/16] watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-14 10:26 ` [PATCH 04/16] watchdog: cadence_wdt: still probe if user supplied timeout is invalid Wolfram Sang
2019-04-14 10:26 ` [PATCH 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-14 10:26 ` [PATCH 06/16] watchdog: hpwdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 07/16] watchdog: i6300esb: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 08/16] watchdog: imx_sc_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 09/16] watchdog: ni903x_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 10/16] watchdog: nic7018_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 11/16] watchdog: renesas_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 12/16] watchdog: sp5100_tco: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 13/16] watchdog: st_lpc_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 14/16] watchdog: stm32_iwdg: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 15/16] watchdog: xen_wdt: " Wolfram Sang
2019-04-14 10:26 ` [PATCH 16/16] watchdog: ziirave_wdt: " Wolfram Sang
2019-04-14 10:30 ` [PATCH 00/16] watchdog: refactor init_timeout and update users Wolfram Sang
2019-04-14 15:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35407697-cbbb-e72b-7aed-ed84a3beb669@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox