From: Florian Fainelli <florian@openwrt.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com,
plagnioj@jcrosoft.com, JM.Lin@atmel.com, wim@iguana.be,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework
Date: Wed, 05 Dec 2012 11:47:39 +0100 [thread overview]
Message-ID: <3976223.KImVV2lC5B@flexo> (raw)
In-Reply-To: <1354671267-19277-3-git-send-email-wenyou.yang@atmel.com>
Hello Wenyou,
On Wednesday 05 December 2012 09:34:21 Wenyou Yang wrote:
> According to the kernel document: convert_drivers_to_kernel_api.txt,
> remove the file_operations struct, miscdevice, and obsolete includes
>
> Since the at91sam watchdog inherent characteristics, add the watchdog
> operations: at91wdt_start, at91wdt_stop and at91wdt_ping.
>
[snip]
>
> +static inline bool watchdog_is_open(struct watchdog_device *wddev)
> +{
> + return test_bit(WDOG_DEV_OPEN, &wddev->status);
> +}
This helper should be moved to include/linux/watchdog.h as it can be useful
for other watchdog drivers as well.
--
Florian
next prev parent reply other threads:[~2012-12-05 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354671267-19277-1-git-send-email-wenyou.yang@atmel.com>
2012-12-05 1:34 ` [v2 PATCH 1/8] watchdog/at91sam9_wdt: Remove at91wdt_private and add at91wdt_drvdata struct Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework Wenyou Yang
2012-12-05 10:47 ` Florian Fainelli [this message]
2012-12-06 0:54 ` Yang, Wenyou
2012-12-05 1:34 ` [v2 PATCH 3/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 4/8] watchdog/at91sam9_wdt: Add nowayout helpers to Watchdog Timer Driver Kernel API Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 5/8] watchdog/at91sam9_wdt: Remove the __initdata of at91wdt_wdd Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver() Wenyou Yang
2012-12-06 18:16 ` Sergei Shtylyov
2012-12-07 7:12 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3976223.KImVV2lC5B@flexo \
--to=florian@openwrt.org \
--cc=JM.Lin@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wenyou.yang@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).