Linux Watchdog driver development
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: Stephan Gerhold <stephan.gerhold@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog
Date: Fri, 19 Dec 2025 13:15:00 +0100	[thread overview]
Message-ID: <3fcd274f-2502-4b3b-8a39-daf5e1938bed@oss.qualcomm.com> (raw)
In-Reply-To: <20251219-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v2-2-fdfc6ba663e6@oss.qualcomm.com>

On 12/19/25 11:00 AM, Abel Vesa wrote:
> The watchdog support in EL1 is SBSA compliant, handled by Gunyah
> hypervisor, but in EL2. the watchdog is an instance of the APSS WDT HW
> block, same as older platforms. So describe the APSS WDT node and mark
> it as reserved, as it will only be enabled in EL2 overlay.
> 
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/hamoa.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> index a17900eacb20..b65dfad71c2f 100644
> --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
> +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
> @@ -8302,6 +8302,14 @@ gic_its: msi-controller@17040000 {
>  			};
>  		};
>  
> +		apss_watchdog: watchdog@17410000 {
> +			compatible = "qcom,apss-wdt-x1e80100", "qcom,kpss-wdt";
> +			reg = <0x0 0x17410000 0x0 0x1000>;
> +			clocks = <&sleep_clk>;
> +			interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
> +			status = "reserved"; /* Accessible in EL2 only */

This is technically incorrect - it's not accessible if Gunyah is
present, which is only somewhat related - if you run a different
hypervisor which doesn't explicitly block access to this region, you
can still access it even though Linux may be running at EL1

Konrad

  reply	other threads:[~2025-12-19 12:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19 10:00 [PATCH v2 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
2025-12-19 10:00 ` [PATCH v2 1/3] dt-bindings: watchdog: Document X1E80100 compatible Abel Vesa
2025-12-19 15:24   ` Guenter Roeck
2025-12-19 10:00 ` [PATCH v2 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
2025-12-19 12:15   ` Konrad Dybcio [this message]
2025-12-23 16:00     ` Abel Vesa
2025-12-23 17:19       ` Konrad Dybcio
2025-12-24  9:48         ` Abel Vesa
2025-12-19 10:00 ` [PATCH v2 3/3] arm64: dts: qcom: x1-el2: Enable " Abel Vesa
2025-12-19 14:22   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fcd274f-2502-4b3b-8a39-daf5e1938bed@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh@kernel.org \
    --cc=stephan.gerhold@linaro.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox