Re: [rtc-linux] [PATCH] watchdog: stmp3xxx: Implement GETBOOTSTATUS

harald
2015-04-20T07:11:08Z

Hi Alexandre,

On Sun, 19 Apr 2015 17:37:43 +0200, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 19/04/2015 at 15:41:42 +0200, harald@ccbib.org wrote :
>> > - use syscon instead of passing callbacks to the watchdog driver
>>
>> I will put looking into this onto my todo list, but I'm not familiar
>> with syscon yet and it is not obvious to me how to port the rtc driver
>> to syscon without breaking devicetree backwards compatibility. So I'd
>> like to defer this for later unless somebody gives me some guidance.
>>
>
> As the rtc driver is the one instantiating the watchdog driver, there is
> no reason why the DT ABI would be broken. You simply have to create
> the syscon in the RTC driver and then pass it to the watchdog driver,
> the same way it is done with the callbacks.

Ok, this is less invasive than what I have been thinking. This makes
sense.

> I can have a look at doing it as I have some i.mx28 platforms.

If you can point me to a driver that is a good reference for your model,
then I can do this myself. Otherwise I'd prefer if you wrote the code.
I can do the testing though, if this helps.

Thanks,
Harald