From: Mike Waychison <mikew@google.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Watchdog Mailing List <linux-watchdog@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC] [PATCH 0/10] Generic Watchdog Timer Driver
Date: Wed, 23 Feb 2011 14:19:18 -0800 [thread overview]
Message-ID: <4D6587E6.2080009@google.com> (raw)
In-Reply-To: <20110223204108.GA6327@infomag.iguana.be>
On 02/23/11 12:41, Wim Van Sebroeck wrote:
> Hi All,
>
> To reduce copying the same code over and over in each watchdog device driver, Alan Cox and myself constructed a new framework/API that consolidates the common watchdog timer driver functions.
>
> This framework/API consists of the following patches:
> part 1: Introduction of the WatchDog Timer Driver Core
> part 2: Add the basic ioctl functionality
> part 3: Add the WDIOC_KEEPALIVE ioctl
> part 4: Add the WDIOC_SETOPTIONS ioctl
> part 5: Add the WDIOC_SETTIMEOUT and WDIOC_GETTIMEOUT ioctl
> part 6: Add orphan control
> part 7: Add the Magic Close feature
> part 8: Add the nowayout feature
> part 9: Add support for a miscdev parent device
> part 10: Add support for extra ioctl calls
>
> Note: I still need to add the minimum and maximum timeout parameters.
> (That will become part 11).
Overall, this looks really good IMO. It goes a long way to setting the
stage for cleaning up the watchdog drivers themselves :)
Reviewed-by: Mike Waychison <mikew@google.com>
next prev parent reply other threads:[~2011-02-23 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 20:41 [RFC] [PATCH 0/10] Generic Watchdog Timer Driver Wim Van Sebroeck
2011-02-23 22:19 ` Mike Waychison [this message]
2011-06-16 13:10 ` Andrea Galbusera
2011-06-17 7:11 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6587E6.2080009@google.com \
--to=mikew@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).