From: Marc Vertes <marc.vertes@sigfox.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: via_wdt: Staticise wdt_pci_table
Date: Mon, 16 Jan 2012 10:09:56 +0100 [thread overview]
Message-ID: <4F13E964.5020207@sigfox.com> (raw)
In-Reply-To: <1326540874.12848.1.camel@phoenix>
Axel Lin wrote:
> It is only used in this driver, so no need to make the symbol global.
>
Agree.
Acked-by: Marc Vertes <marc.vertes@sigfox.com>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/watchdog/via_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index 026b4bb..8b24b00 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
> pci_disable_device(pdev);
> }
>
> -DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> +static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },
prev parent reply other threads:[~2012-01-16 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 11:34 [PATCH] watchdog: via_wdt: Staticise wdt_pci_table Axel Lin
2012-01-16 9:09 ` Marc Vertes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13E964.5020207@sigfox.com \
--to=marc.vertes@sigfox.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).