* [PATCH] watchdog: via_wdt: Staticise wdt_pci_table
@ 2012-01-14 11:34 Axel Lin
2012-01-16 9:09 ` Marc Vertes
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-01-14 11:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Marc Vertes, Wim Van Sebroeck, linux-watchdog
It is only used in this driver, so no need to make the symbol global.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/watchdog/via_wdt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
index 026b4bb..8b24b00 100644
--- a/drivers/watchdog/via_wdt.c
+++ b/drivers/watchdog/via_wdt.c
@@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
pci_disable_device(pdev);
}
-DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
+static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
{ PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: via_wdt: Staticise wdt_pci_table
2012-01-14 11:34 [PATCH] watchdog: via_wdt: Staticise wdt_pci_table Axel Lin
@ 2012-01-16 9:09 ` Marc Vertes
0 siblings, 0 replies; 2+ messages in thread
From: Marc Vertes @ 2012-01-16 9:09 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Wim Van Sebroeck, linux-watchdog
Axel Lin wrote:
> It is only used in this driver, so no need to make the symbol global.
>
Agree.
Acked-by: Marc Vertes <marc.vertes@sigfox.com>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/watchdog/via_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index 026b4bb..8b24b00 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -233,7 +233,7 @@ static void __devexit wdt_remove(struct pci_dev *pdev)
> pci_disable_device(pdev);
> }
>
> -DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> +static DEFINE_PCI_DEVICE_TABLE(wdt_pci_table) = {
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_CX700) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX800) },
> { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_VX855) },
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-16 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-14 11:34 [PATCH] watchdog: via_wdt: Staticise wdt_pci_table Axel Lin
2012-01-16 9:09 ` Marc Vertes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).