From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from na3sys009aog124.obsmtp.com ([74.125.149.151]:47358 "EHLO na3sys009aog124.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755627Ab2AXJtw (ORCPT ); Tue, 24 Jan 2012 04:49:52 -0500 Message-ID: <4F1E7EBA.3090006@ti.com> Date: Tue, 24 Jan 2012 15:19:46 +0530 From: Shubhrajyoti MIME-Version: 1.0 To: Wolfram Sang CC: "Bedia, Vaibhav" , Shubhrajyoti Datta , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-watchdog@vger.kernel.org" Subject: Re: [PATCH RFC 1/2] watchdog : omap_wdt : Implement WDIOC_GETBOOTSTATUS for omap3+ References: <1327317188-14782-1-git-send-email-shubhrajyoti@ti.com> <1327317188-14782-2-git-send-email-shubhrajyoti@ti.com> <20120124093318.GA2609@pengutronix.de> In-Reply-To: <20120124093318.GA2609@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Tuesday 24 January 2012 03:03 PM, Wolfram Sang wrote: >> Just returning the register content does not help much and looking at other >> implementations, like Blackfin, I am guessing this IOCTL is supposed to give >> a yes/no sort of result. > It needs to return WDIOF_* flags as defined in include/linux/watchdog.h. > Check also Documentation/watchdog/watchdog-api.txt for further info. > Yes, not all drivers follow this style, sadly. Yes I agree. > Regards, > > Wolfram >