From: Roland Stigge <stigge@antcom.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be
Subject: Re: [PATCH 0/4] pnx4008: convert to watchdog framework
Date: Thu, 02 Feb 2012 21:02:13 +0100 [thread overview]
Message-ID: <4F2AEBC5.9060308@antcom.de> (raw)
In-Reply-To: <1328204891-32551-1-git-send-email-w.sang@pengutronix.de>
On 02/02/2012 06:48 PM, Wolfram Sang wrote:
> Patch 3/4 is of special interest, because it extends the core to allow to set
> timeouts without having a dedicated callback. Since the core automatically sets
> 'timeout' in the watchdog device (and does limit checking, too), there is
> nothing else left to do for this device since it uses that value every time in
> start/ping.
>
> Please review and consider for inclusion. Roland, if you'd like to test them,
> too, please do and donate "Tested-by" tags. Thanks!
Works for me: Applies cleanly, compiles, boots, watchdog barks
(rebooting appropriately when using /dev/watchdog).
Roland
next prev parent reply other threads:[~2012-02-02 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 17:48 [PATCH 0/4] pnx4008: convert to watchdog framework Wolfram Sang
2012-02-02 17:48 ` [PATCH 1/4] watchdog: pnx4008: cleanup resource handling using managed devices Wolfram Sang
2012-02-02 20:04 ` Roland Stigge
2012-02-02 17:48 ` [PATCH 2/4] watchdog: pnx4008: don't use __raw_-accessors Wolfram Sang
2012-02-02 20:04 ` Roland Stigge
2012-02-02 17:48 ` [PATCH 3/4] watchdog: dev: don't enforce set_timeout() Wolfram Sang
2012-02-02 20:04 ` Roland Stigge
2012-03-14 18:40 ` Wolfram Sang
2012-03-15 21:18 ` Wim Van Sebroeck
2012-02-02 17:48 ` [PATCH 4/4] watchdog: pnx4008: convert driver to use the watchdog framework Wolfram Sang
2012-02-02 20:04 ` Roland Stigge
2012-02-02 20:02 ` Roland Stigge [this message]
2012-02-02 20:23 ` [PATCH 0/4] pnx4008: convert to " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2AEBC5.9060308@antcom.de \
--to=stigge@antcom.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=w.sang@pengutronix.de \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox