Re: [PATCH 1/2 V3] watchdog: Add multiple device support

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 05/21/2012 10:21 PM, Wim Van Sebroeck wrote:
> Hi Tomas,
>
>> Thanks for clarification.
>> BTW the patch is gone again from the tree.
>
> Patches are back but I added some small fixes:
> * watchdog_dev.h should have been watchdog_core.h
> * the file should have been using extern for the function prototypes.
> * introduce subsys_initcall instead of module_init and move that also to the core.
> * make subsys_initcall and module_exit static
> * moved device create code into watchdog_core where it belongs
> * changed busdev to parent
> * integrated Hans's documentation into the respective patches.
>
> Please have a look and test.

Thanks for all the work on merging this, I've re-reviewed the set and
tested it with my convert sch56xx watchdog to the wdog-core patchset.

Everything looks good and works as advertised :)

I've rebased my sch56xx watchdog patchset as my patch titled:
"watchdog_dev: Add support for dynamically allocated watchdog_device structs"
needed rebasing, I'll re-send it after this mail.

Regards,

Hans