From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16536 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950Ab2EVQro (ORCPT ); Tue, 22 May 2012 12:47:44 -0400 Message-ID: <4FBBC428.4010400@redhat.com> Date: Tue, 22 May 2012 18:51:52 +0200 From: Hans de Goede MIME-Version: 1.0 To: Wim Van Sebroeck CC: Tomas Winkler , "linux-watchdog@vger.kernel.org" , Alan Cox Subject: Re: [PATCH 1/2 V3] watchdog: Add multiple device support References: <1337002196-32569-1-git-send-email-tomas.winkler@intel.com> <20120514135209.GM3074@spo001.leaseweb.com> <5B8DA87D05A7694D9FA63FD143655C1B10236D@HASMSX103.ger.corp.intel.com> <20120517071906.GU3074@spo001.leaseweb.com> <20120521202145.GA3074@spo001.leaseweb.com> <4FBB5E0B.7050602@redhat.com> <20120522164124.GF3074@spo001.leaseweb.com> In-Reply-To: <20120522164124.GF3074@spo001.leaseweb.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hi, On 05/22/2012 06:41 PM, Wim Van Sebroeck wrote: > Hi Hans, > >>>> Thanks for clarification. >>>> BTW the patch is gone again from the tree. >>> >>> Patches are back but I added some small fixes: >>> * watchdog_dev.h should have been watchdog_core.h >>> * the file should have been using extern for the function prototypes. >>> * introduce subsys_initcall instead of module_init and move that also to >>> the core. >>> * make subsys_initcall and module_exit static >>> * moved device create code into watchdog_core where it belongs >>> * changed busdev to parent >>> * integrated Hans's documentation into the respective patches. >>> >>> Please have a look and test. >> >> Thanks for all the work on merging this, I've re-reviewed the set and >> tested it with my convert sch56xx watchdog to the wdog-core patchset. >> >> Everything looks good and works as advertised :) >> >> I've rebased my sch56xx watchdog patchset as my patch titled: >> "watchdog_dev: Add support for dynamically allocated watchdog_device >> structs" >> needed rebasing, I'll re-send it after this mail. > > I will split your "watchdog_dev: Add support for dynamically allocated > watchdog_device structs" patch into 3 patches: > 1) rewriting of wrappers (and I will add some extra code to it for > the get_timeleft ioctl). > 2) locking > 3) ref+unref+unregistered. Sounds good! Assuming you manage to finish this tonight, I'll review and test first thing tomorrow morning. Regards, Hans