linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] watchdog: xilinx: Read clock frequency directly from DT node
@ 2012-06-21  6:45 Michal Simek
  2012-06-21 19:04 ` Alejandro Cabrera
  2012-06-26 19:10 ` Wim Van Sebroeck
  0 siblings, 2 replies; 4+ messages in thread
From: Michal Simek @ 2012-06-21  6:45 UTC (permalink / raw)
  To: linux-watchdog
  Cc: devicetree-discuss, Wim Van Sebroeck, Grant Likely, Rob Herring,
	linux-kernel, Michal Simek

Do not use clock-frequency property from parent node.
Use it from watchdog node.

Signed-off-by: Michal Simek <monstr@monstr.eu>
---
 drivers/watchdog/of_xilinx_wdt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index 55d2f66..294fb4e 100644
--- a/drivers/watchdog/of_xilinx_wdt.c
+++ b/drivers/watchdog/of_xilinx_wdt.c
@@ -297,7 +297,7 @@ static int __devinit xwdt_probe(struct platform_device *pdev)
 
 	no_timeout = 0;
 
-	pfreq = (u32 *)of_get_property(pdev->dev.of_node->parent,
+	pfreq = (u32 *)of_get_property(pdev->dev.of_node,
 					"clock-frequency", NULL);
 
 	if (pfreq == NULL) {
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] watchdog: xilinx: Read clock frequency directly from DT node
  2012-06-21  6:45 [PATCH] watchdog: xilinx: Read clock frequency directly from DT node Michal Simek
@ 2012-06-21 19:04 ` Alejandro Cabrera
  2012-06-26 19:10 ` Wim Van Sebroeck
  1 sibling, 0 replies; 4+ messages in thread
From: Alejandro Cabrera @ 2012-06-21 19:04 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-watchdog, devicetree-discuss, Wim Van Sebroeck,
	Grant Likely, Rob Herring, linux-kernel


> Do not use clock-frequency property from parent node.
> Use it from watchdog node.
>
> Signed-off-by: Michal Simek<monstr@monstr.eu>

Acked-By: Alejandro Cabrera <acabrera@udio.cujae.edu.cu>

> ---
>   drivers/watchdog/of_xilinx_wdt.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 55d2f66..294fb4e 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -297,7 +297,7 @@ static int __devinit xwdt_probe(struct platform_device *pdev)
>
>   	no_timeout = 0;
>
> -	pfreq = (u32 *)of_get_property(pdev->dev.of_node->parent,
> +	pfreq = (u32 *)of_get_property(pdev->dev.of_node,
>   					"clock-frequency", NULL);
>
>   	if (pfreq == NULL) {

Participe en la XVI Convencion Cientifica de Ingenieria y Arquitectura del 26 al 30 de noviembre de 2012. La Habana, Cuba: http://ccia.cujae.edu.cu

Consulte la enciclopedia colaborativa cubana. http://www.ecured.cu

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] watchdog: xilinx: Read clock frequency directly from DT node
  2012-06-21  6:45 [PATCH] watchdog: xilinx: Read clock frequency directly from DT node Michal Simek
  2012-06-21 19:04 ` Alejandro Cabrera
@ 2012-06-26 19:10 ` Wim Van Sebroeck
  2012-06-27  7:04   ` Michal Simek
  1 sibling, 1 reply; 4+ messages in thread
From: Wim Van Sebroeck @ 2012-06-26 19:10 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-watchdog, devicetree-discuss, Grant Likely, Rob Herring,
	linux-kernel

Hi Michal,

> Do not use clock-frequency property from parent node.
> Use it from watchdog node.
> 
> Signed-off-by: Michal Simek <monstr@monstr.eu>

Added to linux-watchdog-next.

Kind regards,
Wim.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] watchdog: xilinx: Read clock frequency directly from DT node
  2012-06-26 19:10 ` Wim Van Sebroeck
@ 2012-06-27  7:04   ` Michal Simek
  0 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2012-06-27  7:04 UTC (permalink / raw)
  To: Wim Van Sebroeck
  Cc: linux-watchdog, devicetree-discuss, Grant Likely, Rob Herring,
	linux-kernel

On 06/26/2012 09:10 PM, Wim Van Sebroeck wrote:
> Hi Michal,
>
>> Do not use clock-frequency property from parent node.
>> Use it from watchdog node.
>>
>> Signed-off-by: Michal Simek<monstr@monstr.eu>
>
> Added to linux-watchdog-next.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-06-27  7:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-21  6:45 [PATCH] watchdog: xilinx: Read clock frequency directly from DT node Michal Simek
2012-06-21 19:04 ` Alejandro Cabrera
2012-06-26 19:10 ` Wim Van Sebroeck
2012-06-27  7:04   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).