From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org, JM.Lin@atmel.com,
nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org,
wim@iguana.be, plagnioj@jcrosoft.com
Subject: Re: [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver()
Date: Thu, 06 Dec 2012 21:16:08 +0300 [thread overview]
Message-ID: <50C0E0E8.3020809@mvista.com> (raw)
In-Reply-To: <1354671267-19277-7-git-send-email-wenyou.yang@atmel.com>
Hello.
On 12/05/2012 04:34 AM, Wenyou Yang wrote:
> Using module_platform_driver() replaces module_init() and module_exit()
> and makes the code simpler.
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Cc: wim@iguana.be
> Cc: linux-watchdog@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/watchdog/at91sam9_wdt.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
> index 5afd3fb..a7c0881 100644
> --- a/drivers/watchdog/at91sam9_wdt.c
> +++ b/drivers/watchdog/at91sam9_wdt.c
> @@ -278,6 +278,7 @@ MODULE_DEVICE_TABLE(of, at91_wdt_dt_ids);
> #endif
>
> static struct platform_driver at91wdt_driver = {
> + .probe = at91wdt_probe,
You also need to remove '__init' annotation from that function since the
driver becomes hot-plug aware now.
WBR, Sergei
next prev parent reply other threads:[~2012-12-06 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1354671267-19277-1-git-send-email-wenyou.yang@atmel.com>
2012-12-05 1:34 ` [v2 PATCH 1/8] watchdog/at91sam9_wdt: Remove at91wdt_private and add at91wdt_drvdata struct Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework Wenyou Yang
2012-12-05 10:47 ` Florian Fainelli
2012-12-06 0:54 ` Yang, Wenyou
2012-12-05 1:34 ` [v2 PATCH 3/8] watchdog/at91sam9_wdt: Adjust the options of watchdog_info Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 4/8] watchdog/at91sam9_wdt: Add nowayout helpers to Watchdog Timer Driver Kernel API Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 5/8] watchdog/at91sam9_wdt: Remove the __initdata of at91wdt_wdd Wenyou Yang
2012-12-05 1:34 ` [v2 PATCH 6/8] watchdog/at91sam9_wdt: Use module_platform_driver() Wenyou Yang
2012-12-06 18:16 ` Sergei Shtylyov [this message]
2012-12-07 7:12 ` Yang, Wenyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C0E0E8.3020809@mvista.com \
--to=sshtylyov@mvista.com \
--cc=JM.Lin@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=wenyou.yang@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).