linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jonas Jensen <jonas.jensen@gmail.com>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, arm@kernel.org, arnd@arndb.de
Subject: Re: [PATCH v8] watchdog: Add MOXA ART watchdog driver
Date: Fri, 02 Aug 2013 16:58:45 -0700	[thread overview]
Message-ID: <51FC47B5.5050103@roeck-us.net> (raw)
In-Reply-To: <1375454445-15589-1-git-send-email-jonas.jensen@gmail.com>

On 08/02/2013 07:40 AM, Jonas Jensen wrote:
> This patch adds a watchdog driver for the main hardware watchdog timer
> found on MOXA ART SoCs.
>
> The MOXA ART SoC provides one writable timer register, restarting
> the hardware once it reaches zero. The register is auto decremented
> every APB clock cycle.
>
> Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>

Still wondering where the requirement comes from not to use unlikely()
in probe functions. Must be one of those tribal knowledge things people
have been talking about.

Nevertheless, still

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Guenter


  reply	other threads:[~2013-08-02 23:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 12:29 [PATCH] watchdog: Add MOXA ART watchdog driver Jonas Jensen
2013-07-11 16:35 ` Guenter Roeck
2013-07-16 13:24 ` [PATCH v2] " Jonas Jensen
2013-07-17  9:24   ` [PATCH v3] " Jonas Jensen
2013-07-18 23:05     ` Guenter Roeck
2013-07-19 10:23     ` [PATCH v4] " Jonas Jensen
2013-07-20 16:40       ` Arnd Bergmann
2013-07-21  7:33       ` Guenter Roeck
2013-07-29 10:20       ` [PATCH v5] " Jonas Jensen
2013-07-29 11:05         ` Guenter Roeck
2013-07-29 11:41         ` [PATCH v6] " Jonas Jensen
2013-07-29 11:57           ` Guenter Roeck
2013-07-29 12:33           ` [PATCH v7] " Jonas Jensen
2013-07-29 22:18             ` Guenter Roeck
2013-08-02 11:41             ` Mark Rutland
2013-08-02 14:55               ` Jonas Jensen
2013-08-02 16:39               ` Guenter Roeck
2013-08-05 10:12                 ` Mark Rutland
2013-08-02 14:40             ` [PATCH v8] " Jonas Jensen
2013-08-02 23:58               ` Guenter Roeck [this message]
2013-10-26 15:18               ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FC47B5.5050103@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=jonas.jensen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).