* [PATCH] watchdog: xilinx: Make of_device_id array const
@ 2014-05-07 8:42 Jingoo Han
2014-05-07 11:24 ` Michal Simek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jingoo Han @ 2014-05-07 8:42 UTC (permalink / raw)
To: 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Jingoo Han',
'Michal Simek'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/watchdog/of_xilinx_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index 57ccae8..1e6e28d 100644
--- a/drivers/watchdog/of_xilinx_wdt.c
+++ b/drivers/watchdog/of_xilinx_wdt.c
@@ -225,7 +225,7 @@ static int xwdt_remove(struct platform_device *pdev)
}
/* Match table for of_platform binding */
-static struct of_device_id xwdt_of_match[] = {
+static const struct of_device_id xwdt_of_match[] = {
{ .compatible = "xlnx,xps-timebase-wdt-1.00.a", },
{ .compatible = "xlnx,xps-timebase-wdt-1.01.a", },
{},
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: xilinx: Make of_device_id array const
2014-05-07 8:42 [PATCH] watchdog: xilinx: Make of_device_id array const Jingoo Han
@ 2014-05-07 11:24 ` Michal Simek
2014-05-07 12:25 ` Guenter Roeck
2014-05-26 20:10 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: Michal Simek @ 2014-05-07 11:24 UTC (permalink / raw)
To: Jingoo Han, 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Guenter Roeck', 'Michal Simek'
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On 05/07/2014 10:42 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/of_xilinx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 57ccae8..1e6e28d 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -225,7 +225,7 @@ static int xwdt_remove(struct platform_device *pdev)
> }
>
> /* Match table for of_platform binding */
> -static struct of_device_id xwdt_of_match[] = {
> +static const struct of_device_id xwdt_of_match[] = {
> { .compatible = "xlnx,xps-timebase-wdt-1.00.a", },
> { .compatible = "xlnx,xps-timebase-wdt-1.01.a", },
> {},
>
Reviewed-by: Michal Simek <monstr@monstr.eu>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] watchdog: xilinx: Make of_device_id array const
2014-05-07 8:42 [PATCH] watchdog: xilinx: Make of_device_id array const Jingoo Han
2014-05-07 11:24 ` Michal Simek
@ 2014-05-07 12:25 ` Guenter Roeck
2014-05-26 20:10 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-05-07 12:25 UTC (permalink / raw)
To: Jingoo Han, 'Wim Van Sebroeck'
Cc: linux-watchdog, 'Michal Simek'
On 05/07/2014 01:42 AM, Jingoo Han wrote:
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: xilinx: Make of_device_id array const
2014-05-07 8:42 [PATCH] watchdog: xilinx: Make of_device_id array const Jingoo Han
2014-05-07 11:24 ` Michal Simek
2014-05-07 12:25 ` Guenter Roeck
@ 2014-05-26 20:10 ` Wim Van Sebroeck
2 siblings, 0 replies; 4+ messages in thread
From: Wim Van Sebroeck @ 2014-05-26 20:10 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-watchdog, 'Guenter Roeck', 'Michal Simek'
Hi Jingoo,
> Make of_device_id array const, because all OF functions
> handle it as const.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/watchdog/of_xilinx_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index 57ccae8..1e6e28d 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -225,7 +225,7 @@ static int xwdt_remove(struct platform_device *pdev)
> }
>
> /* Match table for of_platform binding */
> -static struct of_device_id xwdt_of_match[] = {
> +static const struct of_device_id xwdt_of_match[] = {
> { .compatible = "xlnx,xps-timebase-wdt-1.00.a", },
> { .compatible = "xlnx,xps-timebase-wdt-1.01.a", },
> {},
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-26 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 8:42 [PATCH] watchdog: xilinx: Make of_device_id array const Jingoo Han
2014-05-07 11:24 ` Michal Simek
2014-05-07 12:25 ` Guenter Roeck
2014-05-26 20:10 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).