From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-f50.google.com ([209.85.220.50]:42598 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbaJDJkB (ORCPT ); Sat, 4 Oct 2014 05:40:01 -0400 Message-ID: <542FC1CC.90705@gmail.com> Date: Sat, 04 Oct 2014 17:45:48 +0800 From: Chen Gang MIME-Version: 1.0 To: wim@iguana.be, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/watchdog/Kconfig: Let XILINX_WATCHDOG and TEGRA_WATCHDOG depend on HAS_IOMEM References: <542FC064.1030604@gmail.com> In-Reply-To: <542FC064.1030604@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 10/4/14 17:39, Chen Gang wrote: > They need HAS_IOMEM, so let them depend on it, the related error (with > allmodconfig under um): > > MODPOST 1205 modules > ERROR: "syscall" [fs/hostfs/hostfs.ko] undefined! ^ Sorry, the line above is useless for this issue, please skip it. Thanks. > ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined! > ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] undefined! > > > Signed-off-by: Chen Gang > --- > drivers/watchdog/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index a51ccf3..d0ddf90 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -132,6 +132,7 @@ config WM8350_WATCHDOG > > config XILINX_WATCHDOG > tristate "Xilinx Watchdog timer" > + depends on HAS_IOMEM > select WATCHDOG_CORE > help > Watchdog driver for the xps_timebase_wdt ip core. > @@ -472,7 +473,7 @@ config SIRFSOC_WATCHDOG > > config TEGRA_WATCHDOG > tristate "Tegra watchdog" > - depends on ARCH_TEGRA || COMPILE_TEST > + depends on (ARCH_TEGRA || COMPILE_TEST) && HAS_IOMEM > select WATCHDOG_CORE > help > Say Y here to include support for the watchdog timer > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed