RE: [PATCH 2/2] DT: watchdog: Add ImgTec PDC Watchdog Timer binding documentation

Naidu Tellapati
2014-11-14T03:18:38Z

Hi James Hogan & Andrew,

Many thanks for your feedback.

> On Thu, Nov 13, 2014 at 5:08 AM, James Hogan <james.hogan@imgtec.com> wrote:
>> Hi,
>>
>> On 13/11/14 12:58, Jude Abraham wrote:
>>> On Wed, Nov 12, 2014 at 7:18 AM, <Naidu.Tellapati@imgtec.com> wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/watchdog/imgpdc-wdt.txt
>>
>>>>> +- interrupts : Should contain WDT interrupt
>>>
>>>> Not sure the interrupt will really be necessary.
>>>
>>> Ok, We will remove the interrupt.
>>
>> Regardless, there is still an interrupt line coming out of the WDT and
>> interrupt status/clear/enable registers for the single reminder
>> interrupt. IMO it makes sense to describe it in DT even if the driver
>> doesn't [yet] make use it.

> Yes, you're right. Even if we don't currently use the interrupt, it's
> a correct description of the hardware.

OK. We will describe the interrupt in DT. But we will remove all references
to pre-timeout & interrupt from the driver code.

Regards,
Naidu.