From: Guenter Roeck <linux@roeck-us.net>
To: Fabio Estevam <festevam@gmail.com>, wim@iguana.be
Cc: linux-watchdog@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] watchdog: imx2_wdt: Fix the argument of watchdog_active()
Date: Mon, 15 Dec 2014 17:58:17 -0800 [thread overview]
Message-ID: <548F91B9.7000705@roeck-us.net> (raw)
In-Reply-To: <1418690999-28294-1-git-send-email-festevam@gmail.com>
On 12/15/2014 04:49 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following build warning by passing the expected argument type to
> watchdog_active():
>
> drivers/watchdog/imx2_wdt.c: In function 'imx2_wdt_suspend':
> drivers/watchdog/imx2_wdt.c:340:2: warning: passing argument 1 of 'watchdog_active' from incompatible pointer type [enabled by default]
> In file included from drivers/watchdog/imx2_wdt.c:38:0:
> include/linux/watchdog.h:104:20: note: expected 'struct watchdog_device *' but argument is of type 'struct watchdog_device **'
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/imx2_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
> index 51d940b..d6add51 100644
> --- a/drivers/watchdog/imx2_wdt.c
> +++ b/drivers/watchdog/imx2_wdt.c
> @@ -337,7 +337,7 @@ static int imx2_wdt_suspend(struct device *dev)
> imx2_wdt_ping(wdog);
>
> /* Watchdog has been stopped but IP block is still running */
> - if (!watchdog_active(&wdog) && imx2_wdt_is_running(wdev))
> + if (!watchdog_active(wdog) && imx2_wdt_is_running(wdev))
> del_timer_sync(&wdev->timer);
>
> clk_disable_unprepare(wdev->clk);
>
prev parent reply other threads:[~2014-12-16 1:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 0:49 [PATCH] watchdog: imx2_wdt: Fix the argument of watchdog_active() Fabio Estevam
2014-12-16 1:58 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F91B9.7000705@roeck-us.net \
--to=linux@roeck-us.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox