From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from eusmtp01.atmel.com ([212.144.249.243]:24021 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651AbbATPuI (ORCPT ); Tue, 20 Jan 2015 10:50:08 -0500 Message-ID: <54BE7916.4060204@atmel.com> Date: Tue, 20 Jan 2015 16:49:42 +0100 From: Nicolas Ferre MIME-Version: 1.0 To: Alexandre Belloni , Lee Jones CC: Daniel Lezcano , Boris Brezillon , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Samuel Ortiz , Wim Van Sebroeck , Guenter Roeck , , , Subject: Re: [PATCH v3 2/8] mfd: Add atmel-st driver References: <1421077023-30954-1-git-send-email-alexandre.belloni@free-electrons.com> <1421077023-30954-3-git-send-email-alexandre.belloni@free-electrons.com> <20150119094224.GJ21886@x1> <20150119225923.GG5014@piout.net> <20150120094739.GM5767@x1> <20150120150501.GH5014@piout.net> In-Reply-To: <20150120150501.GH5014@piout.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Le 20/01/2015 16:05, Alexandre Belloni a =E9crit : > On 20/01/2015 at 09:47:39 +0000, Lee Jones wrote : >>>> This driver looks pretty pointless. Why can't you request the sys= conf >>>> registers from within the drivers themselves? >>>> >>> >>> How would you probe the watchdog driver then? Would you had the >>> "atmel,at91rm9200-st" compatible there? >>> >>> At some point in time, we should add the reset driver, would you al= so >>> match it on "atmel,at91rm9200-st"? >>> >>> I'm fine with that as this allows to avoid the mfd driver. >> >> I'm sorry, I don't follow. Why can't each driver have their own >> compatible strings? >> >=20 > The same IP provides a clocksource, a watchdog and is also the reset > controller. I think that the DT guidelines requires that the DT > describes the hardware and so use one compatible for that IP; I would add also that the registers within the IP are kind of mixed, there is no way to separate by logical functions. Bye, --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html