From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:37550 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754098AbbCBOLo (ORCPT ); Mon, 2 Mar 2015 09:11:44 -0500 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.82) (envelope-from ) id 1YSR4S-001hkE-9Z for linux-watchdog@vger.kernel.org; Mon, 02 Mar 2015 14:11:44 +0000 Message-ID: <54F46F5E.3020707@roeck-us.net> Date: Mon, 02 Mar 2015 06:10:38 -0800 From: Guenter Roeck MIME-Version: 1.0 To: Boris Brezillon , Thomas Gleixner , Jason Cooper , Peter Zijlstra , Mark Rutland , "Rafael J. Wysocki" CC: Len Brown , Pavel Machek , linux-pm@vger.kernel.org, Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Alessandro Zummo , rtc-linux@googlegroups.com, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Mike Turquette , linux-kernel@vger.kernel.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 5/6] watchdog: at91sam9: request the irq with IRQF_NO_SUSPEND References: <1425287898-15093-1-git-send-email-boris.brezillon@free-electrons.com> <1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1425287898-15093-6-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 03/02/2015 01:18 AM, Boris Brezillon wrote: > The watchdog interrupt (only used when activating software watchdog) > shouldn't be suspended when entering suspend mode, because it is shared > with a timer device (which request the line with IRQF_NO_SUSPEND) and once > the watchdog "Mode Register" has been written, it cannot be changed (which > means we cannot disable the watchdog interrupt when entering suspend). > > Signed-off-by: Boris Brezillon Acked-by: Guenter Roeck > --- > drivers/watchdog/at91sam9_wdt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c > index 6df9405..1443b3c 100644 > --- a/drivers/watchdog/at91sam9_wdt.c > +++ b/drivers/watchdog/at91sam9_wdt.c > @@ -208,7 +208,8 @@ static int at91_wdt_init(struct platform_device *pdev, struct at91wdt *wdt) > > if ((tmp & AT91_WDT_WDFIEN) && wdt->irq) { > err = request_irq(wdt->irq, wdt_interrupt, > - IRQF_SHARED | IRQF_IRQPOLL, > + IRQF_SHARED | IRQF_IRQPOLL | > + IRQF_NO_SUSPEND, > pdev->name, wdt); > if (err) > return err; >