From: David Daney <ddaney.cavm@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Wim Van Sebroeck <wim@iguana.be>,
David Daney <david.daney@cavium.com>,
linux-watchdog@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/3] watchdog: octeon: convert to WATCHDOG_CORE API
Date: Mon, 30 Mar 2015 11:16:16 -0700 [thread overview]
Message-ID: <551992F0.5050809@gmail.com> (raw)
In-Reply-To: <1427565940-22951-1-git-send-email-aaro.koskinen@iki.fi>
On 03/28/2015 11:05 AM, Aaro Koskinen wrote:
> Convert OCTEON watchdog to WATCHDOG_CORE API. This enables support
> for multiple watchdogs on OCTEON boards.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> drivers/watchdog/Kconfig | 1 +
> drivers/watchdog/octeon-wdt-main.c | 185 ++++++++-----------------------------
> 2 files changed, 39 insertions(+), 147 deletions(-)
>
[...]
You didn't seem to say how it was tested.
If you have verified that "echo > /dev/watchdog" produces register dumps
and reboots the board, then the whole series:
Acked-by: David Daney <david.daney@cavium.com>
Thanks for doing this, I had been meaning to make the conversion myself.
David.
next prev parent reply other threads:[~2015-03-30 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 18:05 [PATCH 1/3] watchdog: octeon: convert to WATCHDOG_CORE API Aaro Koskinen
2015-03-28 18:05 ` [PATCH 2/3] watchdog: octeon: fix some trivial coding style issues Aaro Koskinen
2015-03-29 3:33 ` Guenter Roeck
2015-03-28 18:05 ` [PATCH 3/3] watchdog: octeon: use fixed length string for register names Aaro Koskinen
2015-03-29 3:34 ` Guenter Roeck
2015-03-29 3:33 ` [PATCH 1/3] watchdog: octeon: convert to WATCHDOG_CORE API Guenter Roeck
2015-03-30 18:16 ` David Daney [this message]
2015-03-30 18:51 ` Aaro Koskinen
2015-03-30 18:59 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551992F0.5050809@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox