Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

Guenter Roeck
2015-04-02T01:42:22Z

On 04/01/2015 03:22 PM, James Hogan wrote:
> Hi Andrew,
>
> On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote:
>> Since the heartbeat is statically initialized to its default value,
>> watchdog_init_timeout() will never look in the device-tree for a
>> timeout-sec value. Instead of statically initializing heartbeat,
>> fall back to the default timeout value if watchdog_init_timeout()
>> fails.
>
> Whoops. Sorry about that. I wasn't aware that a timeout-sec value was
> expected. It isn't mentioned in the DT binding documentation for this
> device :-(.
>

Hi James,

This is a standard watchdog driver attribute. See
Documentation/watchdog/watchdog-kernel-api.txt.

[ Agreed, it would probably make sense to document that in the bindings. ]

Guenter