From: Stephen Warren <swarren@wwwdotorg.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org, Lee Jones <lee@kernel.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: BCM2835: Move the restart/power_off handling to the WDT driver.
Date: Fri, 24 Apr 2015 22:39:06 -0600 [thread overview]
Message-ID: <553B1A6A.6010205@wwwdotorg.org> (raw)
In-Reply-To: <1429902534-2348-2-git-send-email-eric@anholt.net>
On 04/24/2015 01:08 PM, Eric Anholt wrote:
> Since the WDT is what's used to drive restart and power off, it makes
> more sense to keep it there, where the regs are already mapped and
> definitions for them provided. Note that this means you may need to
> add CONFIG_BCM2835_WDT to retain functionality of your kernel.
The series,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Tested-by: Stephen Warren <swarren@wwwdotorg.org>
> Note that power off has never worked for me, and just reboots as well.
> So I can't say that I've *really* tested the power off code.
The RPi can't actually power itself off, but it used to be the case that
if you rebooted it after setting up a certain register configuration,
the firmware would put the device into a low-power state. This did work
when it was first upstreamed. However, it no longer works. I believe
this was due to a change in the firmware, which is why I don't always
trust the firmware. I should really check what the downstream kernel
does for power off now; I assume it must have changed since the code was
upstreamed.
next prev parent reply other threads:[~2015-04-25 4:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1429902534-2348-1-git-send-email-eric@anholt.net>
2015-04-24 19:08 ` [PATCH 2/2] ARM: BCM2835: Move the restart/power_off handling to the WDT driver Eric Anholt
2015-04-24 19:32 ` Pranith Kumar
2015-04-25 4:39 ` Stephen Warren [this message]
2015-04-25 20:11 ` Arnd Bergmann
2015-04-26 15:35 ` Guenter Roeck
2015-04-27 9:18 ` Arnd Bergmann
2015-04-27 12:44 ` Guenter Roeck
2015-04-27 12:48 ` Arnd Bergmann
2015-04-27 13:28 ` Guenter Roeck
2015-04-27 13:32 ` Arnd Bergmann
2015-04-27 12:58 ` Lubomir Rintel
2015-04-27 16:04 ` Guenter Roeck
2015-04-27 16:05 ` Guenter Roeck
2015-04-27 23:12 ` Eric Anholt
2015-04-28 1:39 ` Guenter Roeck
2015-04-28 9:22 ` Lee Jones
2015-04-28 19:38 ` Eric Anholt
2015-04-27 18:28 ` Lee Jones
2015-04-29 2:35 ` [2/2] " Guenter Roeck
2015-04-29 6:45 ` [PATCH 2/2] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553B1A6A.6010205@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox