From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <55440AA3.2080707@codeaurora.org> Date: Fri, 01 May 2015 18:22:11 -0500 From: Timur Tabi MIME-Version: 1.0 To: Guenter Roeck , Arnd Bergmann , linaro-acpi@lists.linaro.org CC: linux-watchdog@vger.kernel.org, Ashwin Chaugule , Vipul Gandhi , Fu Wei , Al Stone , Wim Van Sebroeck , Hanjun Guo Subject: Re: [Linaro-acpi] [PATCH] watchdog: introduce the ARM64 SBSA watchdog driver References: <1430336034-5275-1-git-send-email-timur@codeaurora.org> <5542F33D.2020206@roeck-us.net> <5543A6E9.1090203@codeaurora.org> <2851853.hEtA2CtVGn@wuerfel> <5543DECA.10006@codeaurora.org> <55440955.6050204@roeck-us.net> In-Reply-To: <55440955.6050204@roeck-us.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit List-ID: Guenter Roeck wrote: > Not really, at least not me. However, there is no other caller of > arch_timer_get_rate, except for the call setting arch_timer_rate. > This suggests that it might not be such a good idea to call > arch_timer_get_rate() and arch_timer_read_counter() in the first place. I don't know of any other way to convert seconds into watchdog ticks. > [ On a side note, arch_timer_get_rate() can return 0 if ARM_ARCH_TIMER > is not configured. You'll need to check for that. ] Check the Kconfig for this driver. It requires ARM_ARCH_TIMER. > It is hard to imagine that the watchdog would be the only driver which > needs this clock. Isn't there some clock API call that can be used > instead ? If there is, I'd love to know it. There's no 'device' for this driver, so I don't think the clk API will work. > As for acpi_parse_entries, we will need some feedback from the acpi > maintainers. If the intent is that this function can be called from > drivers, it should be exported. Agreed. -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.