From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:36737 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbEKIrs (ORCPT ); Mon, 11 May 2015 04:47:48 -0400 Received: by wizk4 with SMTP id k4so96373040wiz.1 for ; Mon, 11 May 2015 01:47:47 -0700 (PDT) Message-ID: <55506CB0.2030909@linaro.org> Date: Mon, 11 May 2015 10:47:44 +0200 From: Daniel Lezcano MIME-Version: 1.0 To: Paul Bolle , Lee Jones CC: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, devicetree@vger.kernel.org, tglx@linutronix.de, wim@iguana.be, a.zummo@towertech.it, linux-watchdog@vger.kernel.org, rtc-linux@googlegroups.com, linux@roeck-us.net Subject: Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-4-git-send-email-lee.jones@linaro.org> <1431074699.13593.4.camel@x220> <20150508093603.GB29044@x1> <1431078730.13593.14.camel@x220> <20150508102938.GD29044@x1> <1431085625.13593.39.camel@x220> In-Reply-To: <1431085625.13593.39.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 05/08/2015 01:47 PM, Paul Bolle wrote: > On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote: >> Ah, you mean from menuconfig. I almost forgot what that was. ;) >> >> I can add a menu option, no problem. > > It's not just menuconfig: > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=3Dy > CONFIG_CLKSRC_ST_LPC=3Dy > CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=3Dy > $ vim .config > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=3Dy > # CONFIG_CLKSRC_ST_LPC is not set > # CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK is not set > $ make ARCH=3Darm silentoldconfig > scripts/kconfig/conf --silentoldconfig Kconfig > # > # configuration written to .config > # > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=3Dy > CONFIG_CLKSRC_ST_LPC=3Dy > CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=3Dy > > So I think that, if you want to be able to set > CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is '= y', > you need to add a prompt. Or have you found a way around this? The general policy is to have non-prompted options in the clocksource's= =20 Kconfig and let the platform's config to select the right components. --=20 Linaro.org =E2=94=82 Open source software fo= r ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-watchdo= g" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html