From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.domeneshop.no ([194.63.252.55]:52475 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756340AbbFPJjg (ORCPT ); Tue, 16 Jun 2015 05:39:36 -0400 Message-ID: <557FEECE.9060909@tronnes.org> Date: Tue, 16 Jun 2015 11:39:26 +0200 From: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= MIME-Version: 1.0 To: Stephen Warren CC: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] watchdog: bcm2835: Add poweroff code for the Raspberry Pi References: <1434195541-28368-1-git-send-email-noralf@tronnes.org> <1434195541-28368-2-git-send-email-noralf@tronnes.org> <557F930E.8010002@wwwdotorg.org> In-Reply-To: <557F930E.8010002@wwwdotorg.org> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable Den 16.06.2015 05:07, skrev Stephen Warren: > On 06/13/2015 05:39 AM, Noralf Tr=C3=B8nnes wrote: >> This adds a new poweroff function to the watchdog driver for the >> Raspberry Pi. Currently poweroff/halt results in a reboot. >> >> The Raspberry Pi firmware uses the RSTS register to know which >> partiton to boot from. The partiton value is spread into bits >> 0, 2, 4, 6, 8, 10. Partiton 63 is a special partition used by >> the firmware to indicate halt. >> >> The firmware made this change in 19 Aug 2013 and was matched >> by the downstream commit: >> Changes for new NOOBS multi partition booting from gsh > I don't understand why we need a new compatible value here; why not > simply modify the existing bcm2835_power_off() function. That is writte= n > to do something that's interpreted by the RPi firmware, not something > that the bcm2835 HW does. > > Admittedly the current name is a bit misleading, but fixing that should > be a separate change to fixing the implementation to do what the curren= t > firmware expects. There are other boards that use the BCM2835 and I didn't want to break th= e behaviour for those that use the reference firmware. Roku 2 device uses this soc, and changing bcm2835_power_off() would break support for it. ODROID-W also use BCM2835, but this is a Pi clone so I don't know if they have matched their firmware behaviour to that of the Pi (admittedly not many boards were made, their source of chips went dry). -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html