Re: [PATCH 00/37] watchdog: Fix parent of watchdog devices

[Guenter Roeck <linux@roeck-us.net>]

On 08/17/2015 09:47 PM, Pratyush Anand wrote:
> Hi,
>
> I posted a query here (https://lkml.org/lkml/2015/8/10/19), but did not get any
> feedback. So, thought to post patches and to seek response.
>
> I need some way to identify the driver/module for a given watchdog node say
> /dev/watchdog0.
>
> Documentation/watchdog/watchdog-api.txt says:
> identity                a string identifying the watchdog driver
>
> However, all the watchdog driver does not define identity as DRV_NAME.
>
> Otherway could be to look for /sys/class/watchdog/watchdog0/device/modalias.
>
> However, many wdt devices does not set its parent and so, we do not see an entry
> for /sys/class/watchdog/watchdog0/device/ in sysfs.
>
> This patch set fixes parent for wdt drivers written in watchdog-core framework.
>
> Exceptions: booke, diag288, mpc8xxx, octeon, softdog and w83627hf -- They do not
> have any parent. Not sure, how we can identify driver for these devices.
>

Series makes sense, but imposes a huge burden on the maintainer.
I think this is one of those changes where a single patch would make much more sense.

I merged all patches into my test repository for build and runtime tests,
but I would suggest to resubmit the series as a single patch.

Thanks,
Guenter