From: Guenter Roeck <linux@roeck-us.net>
To: Oleksij Rempel <linux@rempel-privat.de>, Rob Herring <robh@kernel.org>
Cc: linux-watchdog@vger.kernel.org, wim@iguana.be,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: add Alphascale asm9260-wdt driver
Date: Mon, 23 Nov 2015 07:47:01 -0800 [thread overview]
Message-ID: <565334F5.7020803@roeck-us.net> (raw)
In-Reply-To: <5652E1A7.2090108@rempel-privat.de>
On 11/23/2015 01:51 AM, Oleksij Rempel wrote:
>>>>
>>>> Seems like this should be a generic wdog property.
>>>>
>>>
>>> what do you mean?
>>> Using "mode" instead of "alphascale,mode" and implement it in WD
>>> framework?
>>>
>>
>> You should still read the property in the driver, even it if is made
>> generic.
>> The watchdog framework can't really use the information, most drivers don't
>> support selecting the mode. We can consider moving it into the framework
>> if/when it benefits other drivers.
>>
>> On a side note, I would suggest "software" and "hardware" instead of sw
>> / hw,
>> but that is just a personal preference.
>
> Ok, then i will leave it for now as is. If "mode" will be introduced, it
> can brake compatibility. Using "alphascale,mode" feels save :)
>
Not sure I understand. Using a generic property name doesn't mean anything
about its implementation. Devicetree properties are supposed to be OS and
implementation independent, no ?
Guenter
next prev parent reply other threads:[~2015-11-23 15:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 9:23 [PATCH] watchdog: add Alphascale asm9260-wdt driver Oleksij Rempel
2015-10-20 7:49 ` Oleksij Rempel
2015-10-26 12:31 ` Guenter Roeck
2015-10-27 2:31 ` Guenter Roeck
2015-10-29 7:20 ` Oleksij Rempel
2015-11-05 9:06 ` [PATCH v2] " Oleksij Rempel
2015-11-05 9:06 ` [PATCH v2] watchdog: " Oleksij Rempel
2015-11-05 16:32 ` Guenter Roeck
2015-11-05 20:43 ` Rob Herring
2015-11-23 7:11 ` Oleksij Rempel
2015-11-23 7:26 ` Guenter Roeck
2015-11-23 9:51 ` Oleksij Rempel
2015-11-23 15:47 ` Guenter Roeck [this message]
2015-11-24 21:40 ` [PATCH v3 0/2] " Oleksij Rempel
2015-11-24 21:40 ` [PATCH v3 1/2] watchdog: " Oleksij Rempel
2015-11-25 3:22 ` Guenter Roeck
2015-11-24 21:40 ` [PATCH v3 2/2] DT: watchdog: add Alphascale asm9260 watchdog binding documentation Oleksij Rempel
2015-11-25 20:06 ` Rob Herring
2015-11-25 19:33 ` [PATCH v4 0/2] add Alphascale asm9260-wdt driver Oleksij Rempel
2015-11-25 19:33 ` [PATCH v4 1/2] watchdog: " Oleksij Rempel
2015-11-30 16:10 ` Guenter Roeck
2015-11-30 16:10 ` Guenter Roeck
2015-11-25 19:33 ` [PATCH v4 2/2] DT: watchdog: add Alphascale asm9260 watchdog binding documentation Oleksij Rempel
2015-12-28 21:49 ` [PATCH v4 0/2] add Alphascale asm9260-wdt driver Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565334F5.7020803@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=robh@kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox