linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Martyn Welch <martyn.welch@collabora.co.uk>,
	Wim Van Sebroeck <wim@iguana.be>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v5] Zodiac Aerospace RAVE Switch Watchdog Processor Driver
Date: Tue, 1 Dec 2015 07:19:43 -0800	[thread overview]
Message-ID: <565DBA8F.2070009@roeck-us.net> (raw)
In-Reply-To: <1448964780-2129-1-git-send-email-martyn.welch@collabora.co.uk>

On 12/01/2015 02:13 AM, Martyn Welch wrote:
> This patch adds a driver for the Zodiac Aerospace RAVE Watchdog Procesor.
> This device implements a watchdog timer, accessible over I2C.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Hi Martyn,

Nitpick:

Applying: Zodiac Aerospace RAVE Switch Watchdog Processor Driver
/home/groeck/src/linux-staging/.git/rebase-apply/patch:461: new blank line at EOF.

Also, the subject line should start with "watchdog: ".

Other than that,

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Please fix and resend with my Reviewed-by:.

Thanks,
Guenter


  reply	other threads:[~2015-12-01 15:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 12:03 [PATCH v3 1/2] Add binding documentation for Zodiac Watchdog Timer Martyn Welch
2015-11-25 12:03 ` [PATCH v3 2/2] Zodiac Aerospace RAVE Switch Watchdog Processor Driver Martyn Welch
2015-11-25 14:52   ` Guenter Roeck
2015-11-25 15:36     ` Martyn Welch
2015-11-25 16:10       ` Guenter Roeck
2015-11-25 16:12         ` Martyn Welch
2015-11-25 17:15     ` [PATCH v4] " Martyn Welch
2015-11-30  9:30       ` Martyn Welch
2015-11-30 14:48         ` Guenter Roeck
2015-11-30 15:55       ` Guenter Roeck
2015-11-30 17:26         ` Martyn Welch
2015-11-30 18:10           ` Guenter Roeck
2015-12-01 10:13             ` [PATCH v5] " Martyn Welch
2015-12-01 15:19               ` Guenter Roeck [this message]
2015-12-01 15:32             ` [PATCH v6] watchdog: " Martyn Welch
2015-12-28 21:54               ` Wim Van Sebroeck
2015-11-25 20:06 ` [PATCH v3 1/2] Add binding documentation for Zodiac Watchdog Timer Rob Herring
2015-12-01 15:15 ` [v3,1/2] " Guenter Roeck
2015-12-01 15:38   ` Martyn Welch
2015-12-01 20:24     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=565DBA8F.2070009@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=martyn.welch@collabora.co.uk \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).