From: Wim Coekaerts <wim.coekaerts@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>,
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
wim@iguana.be
Cc: linux-watchdog@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v6] Add sun4v_wdt watchdog driver
Date: Fri, 29 Jan 2016 09:39:23 -0800 [thread overview]
Message-ID: <56ABA3CB.4070904@oracle.com> (raw)
In-Reply-To: <56AB83DA.1020505@roeck-us.net>
On 01/29/2016 07:23 AM, Guenter Roeck wrote:
> On 01/29/2016 07:12 AM, Stanislav Kholmanskikh wrote:
>>
>>
>> On 01/29/2016 12:46 AM, Wim Coekaerts wrote:
>> <cut>
>>> +static const struct watchdog_info sun4v_wdt_ident = {
>>> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>>> + .identity = "sun4v hypervisor watchdog",
>>> + .firmware_version = 0,
>>> +};
>>
>> In accordance to watchdog_ioctl() in drivers/watchdog/watchdog_dev.c
>> WDIOF_KEEPALIVEPING may be needed here as to enable the support of
>> WDIOC_KEEPALIVE ioctl.
>>
>> Correct? So maybe add it then?
>>
> Yes. Not having the flag means that the ioctl is not supported,
> and that keepalives have to be implemented using file i/o.
>
> Wim, oversight or on purpose ?
good catch, oversight from moving from the implementation of the old
_ioctl() in the driver and I didn't have a test for it in my testprogram
so missed it. Added in and tested it.
prev parent reply other threads:[~2016-01-29 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 21:46 [PATCH v6] Add sun4v_wdt watchdog driver Wim Coekaerts
2016-01-28 22:50 ` Julian Calaby
2016-01-28 22:53 ` Wim Coekaerts
2016-01-29 0:24 ` Guenter Roeck
2016-01-29 0:35 ` Wim Coekaerts
2016-01-29 11:56 ` Stanislav Kholmanskikh
2016-01-29 15:12 ` Stanislav Kholmanskikh
2016-01-29 15:23 ` Guenter Roeck
2016-01-29 17:39 ` Wim Coekaerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56ABA3CB.4070904@oracle.com \
--to=wim.coekaerts@oracle.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sparclinux@vger.kernel.org \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).